Skip to content

fix: re-enable async logging with proper shutdown flushing #2779

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
ivanauth wants to merge 3 commits into
base: main
Choose a base branch
from

ci: retrigger after runner infrastructure failure

96b842e
Select commit
Loading
Failed to load commit list.
Draft

fix: re-enable async logging with proper shutdown flushing #2779

ci: retrigger after runner infrastructure failure
96b842e
Select commit
Loading
Failed to load commit list.
Codecov / codecov/patch succeeded Apr 16, 2026 in 0s

85.62% of diff hit (target 73.66%)

View this Pull Request on Codecov

85.62% of diff hit (target 73.66%)

Annotations

Check warning on line 23 in cmd/spicedb/main.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

cmd/spicedb/main.go#L23 

Added line #L23 was not covered by tests

Check warning on line 26 in cmd/spicedb/main.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

cmd/spicedb/main.go#L26 

Added line #L26 was not covered by tests

Check warning on line 36 in cmd/spicedb/main.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

cmd/spicedb/main.go#L33-L36 

Added lines #L33 - L36 were not covered by tests

Check warning on line 49 in cmd/spicedb/main.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

cmd/spicedb/main.go#L48-L49 

Added lines #L48 - L49 were not covered by tests

Check warning on line 58 in cmd/spicedb/main.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

cmd/spicedb/main.go#L58 

Added line #L58 was not covered by tests

Check warning on line 60 in cmd/spicedb/main.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

cmd/spicedb/main.go#L60 

Added line #L60 was not covered by tests

Check warning on line 63 in cmd/spicedb/main.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

cmd/spicedb/main.go#L63 

Added line #L63 was not covered by tests

Check warning on line 91 in internal/logging/logger.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

internal/logging/logger.go#L90-L91 

Added lines #L90 - L91 were not covered by tests

Check warning on line 50 in pkg/cmd/server/logging_run_e.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

pkg/cmd/server/logging_run_e.go#L49-L50 

Added lines #L49 - L50 were not covered by tests

Check warning on line 71 in pkg/cmd/server/logging_run_e.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

pkg/cmd/server/logging_run_e.go#L70-L71 

Added lines #L70 - L71 were not covered by tests
View more details on Codecov