fix: re-enable async logging with proper shutdown flushing#2779
Draft
ivanauth wants to merge 3 commits intoauthzed:mainfrom
Draft
fix: re-enable async logging with proper shutdown flushing#2779ivanauth wants to merge 3 commits intoauthzed:mainfrom
ivanauth wants to merge 3 commits intoauthzed:mainfrom
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #2779 +/- ##
==========================================
- Coverage 73.66% 73.64% -0.01%
==========================================
Files 499 500 +1
Lines 60165 60307 +142
==========================================
+ Hits 44312 44409 +97
- Misses 12666 12700 +34
- Partials 3187 3198 +11 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
d4136c5 to
d5db6cf
Compare
acc473d to
3b4d309
Compare
e15b28a to
31234ae
Compare
31234ae to
19f4ae0
Compare
Contributor
|
We own |
Contributor
Author
|
Update: cobrautil fix submitted Instead of duplicating cobrautil's logging setup, I've submitted a fix upstream: jzelinskie/cobrautil#66 That PR:
Once that's merged and tagged, this PR can be significantly simplified:
cc @tstirrat15 per your suggestion to fix it in cobrautil |
97e61d1 to
96b842e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #889
Async logging was disabled because nothing was flushing the diode.Writer buffer on shutdown - logs were getting lost. The cobrazerolog library hides the closer so we couldn't fix it there.
This creates our own logging setup that exposes the closer, stores it globally, and flushes it via
defer log.Close()in main. Also restructured main() to return an int so defers actually run before exit.