Skip to content

fix: re-enable async logging with proper shutdown flushing #2779

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
ivanauth wants to merge 3 commits into
base: main
Choose a base branch
from

ci: retrigger after runner infrastructure failure

96b842e
Select commit
Loading
Failed to load commit list.
Draft

fix: re-enable async logging with proper shutdown flushing #2779

ci: retrigger after runner infrastructure failure
96b842e
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Apr 16, 2026 in 0s

73.64% (target 75.00%)

View this Pull Request on Codecov

73.64% (target 75.00%)

Details

Codecov Report

❌ Patch coverage is 85.61151% with 20 lines in your changes missing coverage. Please review.
✅ Project coverage is 73.64%. Comparing base (fa85ab8) to head (96b842e).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
cmd/spicedb/main.go 0.00% 11 Missing ⚠️
pkg/cmd/server/logging_run_e.go 88.24% 4 Missing and 2 partials ⚠️
internal/logging/logger.go 95.84% 2 Missing and 1 partial ⚠️

❌ Your project check has failed because the head coverage (73.64%) is below the target coverage (75.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2779      +/-   ##
==========================================
- Coverage   73.66%   73.64%   -0.01%     
==========================================
  Files         499      500       +1     
  Lines       60165    60307     +142     
==========================================
+ Hits        44312    44409      +97     
- Misses      12666    12700      +34     
- Partials     3187     3198      +11

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
View more details on Codecov