ToolBar Buttons refactoring#1180
Conversation
✅ Deploy Preview for voluble-nougat-015dd1 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
mircealungu
left a comment
There was a problem hiding this comment.
Same good direction as #1181. Two things:
-
.sc.js= styled-components in this repo — every other.sc.jsexportsstyled.…, but the new ones export plain JS objects, so the name is misleading. Either make them real styled-components or rename to plainstyles.js. (Toggle/icon/text-size split itself is clean, and I confirmed thetoggle()→onToggle(!checked)change is behavior-equivalent. 👍) -
Dead duplicated exports in
ToolbarButtons.sc.js— only 4 of the 10 exports are imported.toolbarButtonTrigger/toolbarIconnow live inSettingsIconButton.sc.js, andfontSizeButtonStyle/fontSizeRow/fontSizeControls/fontSizeValuenow live inTextSizeControl.sc.js. The toolbar copies are never used — please delete those 6 so the styles aren't defined in two places.
|
@mircealungu fixed! |
separated Toggles into a new component
separated styles