devided sharedArticleErrorDialog from the handler#1179
Conversation
✅ Deploy Preview for voluble-nougat-015dd1 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
because it was not used anywhere
mircealungu
left a comment
mircealungu
left a comment
There was a problem hiding this comment.
Nicest of the batch — ErrorDialog is genuine reuse (both the article and video handlers had a duplicated error screen, now one parameterized component), and I confirmed the SoundPlayer deletion is safe: nothing references it, and the getLinkToFullArticleReadout API it used is still called by the speech modules. 👍
One thing, same as #1180/#1181: these .sc.js files export plain JS objects, but .sc.js means styled-components everywhere else in the repo — make them styled-components or rename to styles.js. (And #666 in errorDialogDescription could come from components/colors while you're in there.)
(The trailing-comma / line-join reflow in the two handler files is on us, not you — master isn't prettier-clean and there's no enforced hook yet. We'll do a repo-wide sweep so this stops landing in everyone's diffs.)
|
@mircealungu done! |
2 participants
+Deleted SoundPlayer because it wasn't used anywhere