divided report dialog and report icon#1178
Open
AnnieeBennie wants to merge 6 commits into
Open
Conversation
✅ Deploy Preview for voluble-nougat-015dd1 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
mircealungu
reviewed
Jun 30, 2026
mircealungu
left a comment
mircealungu
left a comment
Member
There was a problem hiding this comment.
Best-decomposed of the set — clean container/presentational split, and I confirmed the prop wiring keeps behavior identical. ReportDialog's defaults also make it reusable for a future "report video", nice. Three small things:
.sc.jsnaming — note these are MUIsxobjects (one's a(theme) =>callback), so they can't be styled-components like the rest of the repo's.sc.js. Simplest fix is to rename the file toReportDialog.styles.jsso it's not mislabeled.ReportIconduplicatesSettingsIconButton(from #1180) — samepadding/cursor/flexwrapper +#999icon, only the glyph differs. Worth collapsing the two into one sharedIconButtonthat takes an icon +ariaLabelinstead of two near-identical files.- Tiny pre-existing bug you're inheriting:
flexDisplay: "row"inreportDialogContentStylesisn't a real property (no-op) — drop it, or make itflexDirectionif a column was actually intended.
Otherwise 👍
Collaborator
Author
|
@mircealungu done! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
+divided report dialog and report icon
+renamed ReportBroken => ReportBrokenArticle
+created a separate file for report dialog styles