fix(opentelemetry-collector): support externalTrafficPolicy for NodePort services - #2375
Merged
jaronoff97 merged 1 commit intoSep 5, 2026
Conversation
marcschaeferger
requested review from
a team,
TylerHelmuth,
dmitryax and
povilasv
as code owners
August 27, 2026 22:48
jaronoff97
approved these changes
Sep 3, 2026
jaronoff97
left a comment
jaronoff97
left a comment
Contributor
There was a problem hiding this comment.
can you fix the conflicts? happy to merge post conflict resolution.
…ort services Kubernetes accepts spec.externalTrafficPolicy on any externally-accessible Service, which includes NodePort, but the chart emitted it only for LoadBalancer, silently dropping the value for NodePort users. Continues open-telemetry#2038, originally proposed by @grzegdl Signed-off-by: Marc Schäfer <git@marcschaeferger.de>
marcschaeferger
force-pushed
the
fix/collector-nodeport-external-traffic-policy
branch
from
September 5, 2026 10:47
160e2c3 to
37615ba
Compare
Contributor
Author
|
@jaronoff97 Conflicts resolved |
jaronoff97
approved these changes
Sep 5, 2026
marcschaeferger
deleted the
fix/collector-nodeport-external-traffic-policy
branch
September 6, 2026 21:08
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Kubernetes accepts spec.externalTrafficPolicy on any externally-accessible Service, which includes NodePort, but the chart emitted it only for LoadBalancer, silently dropping the value for NodePort users.
Link to tracking issue
Continues #2038, originally proposed by @grzegdl
Authorship