Skip to content

[RECONSTRUCTION] [GCC16] cleanup for unused variables#50998

Merged
cmsbuild merged 1 commit into
cms-sw:masterfrom
smuzaffar:reconstruction-gcc16-fix-unsed
May 20, 2026
Merged

[RECONSTRUCTION] [GCC16] cleanup for unused variables#50998
cmsbuild merged 1 commit into
cms-sw:masterfrom
smuzaffar:reconstruction-gcc16-fix-unsed

Conversation

@smuzaffar
Copy link
Copy Markdown
Contributor

Cleanup set but unused variables which are causing build errors for GCC16 IBs https://cmssdt.cern.ch/SDT/cgi-bin/showBuildLogs.py/el9_amd64_gcc16/www/tue/17.0-tue-23/CMSSW_17_0_X_2026-05-19-2300

@cmsbuild
Copy link
Copy Markdown
Contributor

cmsbuild commented May 20, 2026

cms-bot internal usage

@cmsbuild
Copy link
Copy Markdown
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-50998/49413

@smuzaffar
Copy link
Copy Markdown
Contributor Author

please test

@cmsbuild
Copy link
Copy Markdown
Contributor

A new Pull Request was created by @smuzaffar for master.

It involves the following packages:

  • RecoMuon/TrackerSeedGenerator (reconstruction)
  • RecoMuon/TrackingTools (reconstruction)
  • RecoTracker/ConversionSeedGenerators (reconstruction)
  • RecoVertex/AdaptiveVertexFinder (reconstruction)

@Moanwar, @jfernan2, @mandrenguyen, @srimanob can you please review it and eventually sign? Thanks.
@24LopezR, @AlexDeMoor, @CeliaFernandez, @Fedespring, @GiacomoSguazzoni, @HuguesBrun, @Ming-Yan, @Senphy, @VinInn, @VourMa, @abbiendi, @andrzejnovak, @bellan, @castaned, @cericeci, @dgulhan, @elusian, @fabiocos, @felicepantaleo, @fsimone91, @gpetruc, @jhgoh, @llunerti, @martinamalberti, @mmasciov, @mmusich, @mtosi, @pavlo-kashko, @philippgadow, @rociovilar, @rovere, @trocino this is something you requested to watch as well.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Copy Markdown
Contributor

+1

Size: This PR adds an extra 40KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b9bf82/53371/summary.html
COMMIT: f85c4d1
CMSSW: CMSSW_17_0_X_2026-05-19-2300/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/50998/53371/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 1 lines to the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 10 differences found in the comparisons
  • DQMHistoTests: Total files compared: 55
  • DQMHistoTests: Total histograms compared: 4432276
  • DQMHistoTests: Total failures: 9
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 4432247
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 54 files compared)
  • Checked 235 log files, 207 edm output root files, 55 DQM output files
  • TriggerResults: no differences found

@Moanwar
Copy link
Copy Markdown
Contributor

Moanwar commented May 20, 2026

+1

@cmsbuild
Copy link
Copy Markdown
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @mandrenguyen, @ftenchini (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Copy Markdown
Contributor

+1

@cmsbuild cmsbuild merged commit 1f8b4e6 into cms-sw:master May 20, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants