[20_0_X] Move stored types in io_v1 namespace, reset class versions to 3#50968
Open
makortel wants to merge 1 commit into
Open
[20_0_X] Move stored types in io_v1 namespace, reset class versions to 3#50968makortel wants to merge 1 commit into
makortel wants to merge 1 commit into
Conversation
Contributor
Author
|
hold Until 20_0_X opens |
cmsbuild
added
reconstruction-pending
simulation-pending
dqm-pending
l1-pending
hlt-pending
core-pending
analysis-pending
alca-pending
daq-pending
fastsim-pending
generators-pending
visualization-pending
pending-signatures
tests-pending
orp-pending
hold
code-checks-pending
xpog-pending
tracking
trk
changes-dataformats
labels
Contributor
|
cms-bot internal usage |
Contributor
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-50968/49372
|
Contributor
|
Pull request has been put on hold by @makortel |
Contributor
|
A new Pull Request was created by @makortel for master. It involves the following packages:
@Alejandro1400, @BenjaminRS, @Dr15Jones, @JanChyczynski, @Martin-Grunewald, @Moanwar, @alja, @arunhep, @atpathak, @battibass, @civanch, @cmsbuild, @ctarricone, @emeschi, @ftorrresd, @gabrielmscampos, @jfernan2, @kpedro88, @lviliani, @makortel, @mandrenguyen, @mdhildreth, @mkirsano, @mmusich, @perrotta, @quinnanm, @rseidita, @sensrcn, @smorovic, @smuzaffar, @srimanob, @ssekmen, @theofil, @tvami can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
Contributor
Author
Contributor
|
+1 |
Dr15Jones
suggested changes
May 19, 2026
| </class> | ||
| <class name="HFNoseDetId" ClassVersion="0"> | ||
| <version ClassVersion="0" checksum="1469396081"/> | ||
| <class name="HFNoseDetId" ClassVersion="3"> |
Contributor
There was a problem hiding this comment.
Isn't version 0 basically a do not store?
Contributor
Author
| <class name="HFNoseTriggerDetId" ClassVersion="-1"> | ||
| <version ClassVersion="-1" checksum="1686145543"/> | ||
| <version ClassVersion="0" checksum="1469396081"/> | ||
| <class name="HFNoseTriggerDetId" ClassVersion="3"> |
Contributor
There was a problem hiding this comment.
Any idea what -1 was meant to be?
Contributor
Author
This was referenced May 19, 2026
Closed
Contributor
Bot reports warnings for files directly touched by PR or files which use (directly or indirectly) a file changed in the PR. I think in this case, one of changed header is included in |
makortel
force-pushed
the
evoIntegrationDataFormats
branch
from
301952f to
7b40d16
Compare
Contributor
Author
|
@Dr15Jones' comments about changing the accented E and not all member functions in a source being inside |
The io_v1 namespace allows schema evolution of complex cases (e.g. pointed-to container type of edm::Ref being changed) that ROOT's schema evolution can not support. Moving classes to io_v1 breaks backwards compatibility for these types that was agreed to be done in CMSSW_20_0_0 that serves a start of Phase 2 (only) targeting software. Taking advantage of the backwards compatiblity break, the class versions are reset to 3. In addition, include two complex schema evolution cases that were too difficult earlier - Make PFCandidate to no longer inherit from CompositeCandidate - Reduce use of RangeMap in muon code
makortel
force-pushed
the
evoIntegrationDataFormats
branch
from
7b40d16 to
88e2876
Compare
Contributor
Author
|
Rebased to fix the conflict |
Contributor
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-50968/49426
|
Contributor
|
Pull request #50968 was updated. @Alejandro1400, @BenjaminRS, @Dr15Jones, @JanChyczynski, @Martin-Grunewald, @Moanwar, @arunhep, @atpathak, @battibass, @civanch, @cmsbuild, @ctarricone, @ftorrresd, @gabrielmscampos, @jfernan2, @kpedro88, @lviliani, @makortel, @mandrenguyen, @mdhildreth, @mkirsano, @mmusich, @perrotta, @quinnanm, @rseidita, @sensrcn, @smuzaffar, @srimanob, @ssekmen, @theofil can you please check and sign again. |
Contributor
Author
Contributor
Author
|
@cmsbuild, please test |
Contributor
|
-1 Failed Tests: Build ClangBuild The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
You can see more details here: Failed BuildI found compilation error when building: ++ SCRAM_NOEDM_CHECKS=yes ++ /usr/bin/time -v scram build -v -k -j 16 ***WARNING: Multiple usage of "DataFormatsL1DTTrackFinder". Please cleanup "lib" in "export" section of "src/DataFormats/L1DTTrackFinder/BuildFile.xml" >> Local Products Rules ..... started >> Local Products Rules ..... done gmake: Circular tmp/el8_amd64_gcc13/cache/cuda_dlink/RecoTrackerLSTCoreCudaAsync <- tmp/el8_amd64_gcc13/cache/cuda_dlink/RecoTrackerLSTCoreCudaAsync dependency dropped. gmake: Circular tmp/el8_amd64_gcc13/cache/rocm_dlink/RecoTrackerLSTCoreROCmAsync <- tmp/el8_amd64_gcc13/cache/rocm_dlink/RecoTrackerLSTCoreROCmAsync dependency dropped. >> Building CMSSW version CMSSW_17_0_X_2026-05-20-1100 ---- >> Creating project symlinks >> Entering Package Alignment/CommonAlignmentProducer >> Entering Package CondFormats/Alignment Failed Clang BuildI found compilation error while trying to compile with clang. Command used: >> Entering Package TopQuarkAnalysis/TopSkimming >> Entering Package TopQuarkAnalysis/TopTools >> Entering Package TrackPropagation/Geant4e >> Entering Package Utilities/ReleaseScripts >> Compile sequence completed for CMSSW CMSSW_17_0_X_2026-05-20-1100 gmake: *** [There are compilation/build errors. Please see the detail log above.] Error 1 Command exited with non-zero status 1 Command being timed: "scram build -k -j 32 COMPILER=llvm compile BUILD_LOG=yes" User time (seconds): 10984.20 System time (seconds): 1170.33 Percent of CPU this job got: 1360% |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR description:
This PR integrates the data format changes prototyped and tested in the EVOLUTION_X branch to the
masterbranch for 20_0_X. Following the strategy agreed in ORP 2026-05-05, it is opened already now to allow it to be reviewed such that it could be merged quickly when the master branch moves to 20_0_X.This PR includes
io_v1namespace to allow schema evolution for complex cases that ROOT's schema evolution can not support (e.g. pointed-to container type of edm::Ref being changed)For more information please see the ORP 2026-05-05 presentation and the earlier talks linked there.
This PR is unusual in several ways:
git show -b b104b18evolutionlabel https://github.com/cms-sw/cmssw/pulls?q=is%3Apr+label%3Aevolution+is%3AclosedResolves cms-sw/framework-team#2227
PR validation:
None beyond the tests in the EVOLUTION_X IBs. Checked on CMSSW_17_0_X_2026-05-18-1100 that cherry-picking #50953, #50954, and this PR shows no difference wrt. CMSSW_17_0_EVOLUTION_X branch.