Merge pull request #50998 from smuzaffar/reconstruction-gcc16-fix-unsed

[RECONSTRUCTION] [GCC16] cleanup for unused variables

Author: cmsbuild

RecoMuon/TrackerSeedGenerator/plugins/TSGFromPropagation.cc

@@ -118,8 +118,7 @@ void TSGFromPropagation::trackerSeeds(const TrackCand& staMuon,
       if (alltm.size() > 5)
         alltm.erase(alltm.begin() + 5, alltm.end());
 
-      int i = 0;
-      for (std::vector<TrajectoryMeasurement>::const_iterator itm = alltm.begin(); itm != alltm.end(); itm++, i++) {
+      for (std::vector<TrajectoryMeasurement>::const_iterator itm = alltm.begin(); itm != alltm.end(); itm++) {
         TrajectoryStateOnSurface updatedTSOS = updator()->update(itm->predictedState(), *(itm->recHit()));
         if (updatedTSOS.isValid() && passSelection(updatedTSOS)) {
           edm::OwnVector<TrackingRecHit> container;

RecoMuon/TrackingTools/src/MuonTrajectoryCleaner.cc

@@ -195,9 +195,7 @@ void MuonTrajectoryCleaner::clean(TrajectoryContainer& trajC,
       seedToSeedsMap = std::make_unique<L2SeedAssoc>(seedsHandle, seedsHandle);
     }
 
-    int seedcnt(0);
-
-    for (map<int, vector<int> >::iterator itmap = seedmap.begin(); itmap != seedmap.end(); ++itmap, ++seedcnt) {
+    for (map<int, vector<int> >::iterator itmap = seedmap.begin(); itmap != seedmap.end(); ++itmap) {
       edm::RefToBase<TrajectorySeed> tmpSeedRef1 = trajC[(*itmap).first]->seedRef();
       edm::Ref<L2MuonTrajectorySeedCollection> tmpL2SeedRef1 =
           tmpSeedRef1.castTo<edm::Ref<L2MuonTrajectorySeedCollection> >();

RecoTracker/ConversionSeedGenerators/plugins/PhotonConversionTrajectorySeedProducerFromSingleLegAlgo.cc

@@ -106,16 +106,20 @@ void PhotonConversionTrajectorySeedProducerFromSingleLegAlgo::loopOnTracks() {
     return;
   }
 
-  size_t idx = 0;
   _countSeedTracks = 0;
 
 #ifdef debugTSPFSLA
+  size_t idx = 0;
   size_t sel = 0;
   ss.str("");
 #endif
 
   for (reco::TrackCollection::const_iterator tr = trackCollectionH->begin(); tr != trackCollectionH->end();
+#ifdef debugTSPFSLA
        tr++, idx++) {
+#else
+       tr++) {
+#endif
     if (rejectTrack(*tr))
       continue;
     std::vector<reco::Vertex> selectedPriVtxCompatibleWithTrack;

RecoVertex/AdaptiveVertexFinder/plugins/InclusiveVertexFinder.h

@@ -229,15 +229,13 @@ void TemplatedInclusiveVertexFinder<InputContainer, VTX>::produce(edm::Event &ev
     }
     BeamSpot bs(pv.position(), 0.0, 0.0, 0.0, 0.0, cov, BeamSpot::Unknown);
 
-    int i = 0;
 #ifdef VTXDEBUG
-
     std::cout << "CLUSTERS " << clusters.size() << std::endl;
 #endif
 
     for (std::vector<TracksClusteringFromDisplacedSeed::Cluster>::iterator cluster = clusters.begin();
          cluster != clusters.end();
-         ++cluster, ++i) {
+         ++cluster) {
       if (cluster->tracks.size() < 2 || cluster->tracks.size() > maxNTracks)
         continue;
       std::vector<TransientVertex> vertices;

RecoVertex/AdaptiveVertexFinder/src/TracksClusteringFromDisplacedSeed.cc

@@ -116,9 +116,12 @@ std::vector<TracksClusteringFromDisplacedSeed::Cluster> TracksClusteringFromDisp
   }
 
   std::vector<Cluster> clusters;
+#ifdef VTXDEBUG
   int i = 0;
-  for (std::vector<TransientTrack>::const_iterator s = seeds.begin(); s != seeds.end(); ++s, ++i) {
+#endif
+  for (std::vector<TransientTrack>::const_iterator s = seeds.begin(); s != seeds.end(); ++s) {
 #ifdef VTXDEBUG
+    i++;
     std::cout << "Seed N. " << i << std::endl;
 #endif  // VTXDEBUG
     std::pair<std::vector<reco::TransientTrack>, GlobalPoint> ntracks = nearTracks(*s, selectedTracks, pv);