Skip to content

DQM/SiTrackerPhase2: Streamline and clean up DQM code#50936

Merged
cmsbuild merged 10 commits into
cms-sw:masterfrom
brandiskip:clean_up
May 19, 2026
Merged

DQM/SiTrackerPhase2: Streamline and clean up DQM code#50936
cmsbuild merged 10 commits into
cms-sw:masterfrom
brandiskip:clean_up

Conversation

@brandiskip
Copy link
Copy Markdown
Contributor

PR description:

Used existing helper functions in TrackerPhase2DQMUtil.cc (with declarations in TrackerPhase2DQMUtil.h) to reduce redundancy in bookHistograms and added new helper functions for fillDescriptions across the following files:

Renamed histogram Track_LQ_Eta_ECStubs to Track_All_Eta_ECStubs to correct the naming convention.

Updated x-axis range and binning for d0 histograms to match range found in Validation package.

Removed magic numbers for the number of discs in Phase2OTMonitorTTStub.cc, replacing them with a call to Settings.h.

The updated DQM output ROOT file can be reviewed here.

Updated histograms in the following DQM folders:

  • TrackerPhase2OTL1Track
  • TrackerPhase2OTStub
  • TrackerPhase2TTCluster

PR validation:

scram build code-checks
scram build code-format

@cmsbuild
Copy link
Copy Markdown
Contributor

cmsbuild commented May 13, 2026

cms-bot internal usage

@cmsbuild
Copy link
Copy Markdown
Contributor

@cmsbuild
Copy link
Copy Markdown
Contributor

A new Pull Request was created by @brandiskip for master.

It involves the following packages:

  • DQM/SiTrackerPhase2 (dqm)

@cmsbuild, @ctarricone, @gabrielmscampos, @rseidita can you please review it and eventually sign? Thanks.
@arossi83, @mmusich, @richa2710, @sroychow this is something you requested to watch as well.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@gabrielmscampos
Copy link
Copy Markdown
Member

please test

@cmsbuild
Copy link
Copy Markdown
Contributor

+1

Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6e1ff5/53267/summary.html
COMMIT: 7ddae8d
CMSSW: CMSSW_17_0_X_2026-05-14-2300/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/50936/53267/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 4 lines from the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 53
  • DQMHistoTests: Total histograms compared: 4187163
  • DQMHistoTests: Total failures: 38
  • DQMHistoTests: Total nulls: 6
  • DQMHistoTests: Total successes: 4187099
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 1.995 KiB( 52 files compared)
  • DQMHistoSizes: changed ( 34434.0,... ): 0.399 KiB TrackerPhase2OTL1Track/Tracks
  • Checked 227 log files, 197 edm output root files, 53 DQM output files
  • TriggerResults: no differences found

@gabrielmscampos
Copy link
Copy Markdown
Member

+dqm

@cmsbuild
Copy link
Copy Markdown
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @mandrenguyen, @ftenchini (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Copy Markdown
Contributor

+1

@cmsbuild cmsbuild merged commit cff48c5 into cms-sw:master May 19, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants