DQM/SiTrackerPhase2: Streamline and clean up DQM code#50936
Conversation
…illDescriptions by use of helper functions, replace disc magic number with trklet::N_DISK
…dd1DDesc and add2DDesc
…ctions and change d0 hist range
|
cms-bot internal usage |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-50936/49337 |
|
A new Pull Request was created by @brandiskip for master. It involves the following packages:
@cmsbuild, @ctarricone, @gabrielmscampos, @rseidita can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
please test |
|
+1 Size: This PR adds an extra 16KB to repository Comparison SummarySummary:
|
|
+dqm |
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @mandrenguyen, @ftenchini (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 |
PR description:
Used existing helper functions in TrackerPhase2DQMUtil.cc (with declarations in TrackerPhase2DQMUtil.h) to reduce redundancy in
bookHistogramsand added new helper functions forfillDescriptionsacross the following files:Renamed histogram Track_LQ_Eta_ECStubs to Track_All_Eta_ECStubs to correct the naming convention.
Updated x-axis range and binning for
d0histograms to match range found in Validation package.Removed magic numbers for the number of discs in Phase2OTMonitorTTStub.cc, replacing them with a call to
Settings.h.The updated DQM output ROOT file can be reviewed here.
Updated histograms in the following DQM folders:
TrackerPhase2OTL1TrackTrackerPhase2OTStubTrackerPhase2TTClusterPR validation:
scram build code-checks
scram build code-format