Skip to content

Update NGJet model version#50975

Merged
cmsbuild merged 1 commit into
cms-sw:masterfrom
Chriisbrown:L1TSC4NGJet_Update_version
May 20, 2026
Merged

Update NGJet model version#50975
cmsbuild merged 1 commit into
cms-sw:masterfrom
Chriisbrown:L1TSC4NGJet_Update_version

Conversation

@Chriisbrown
Copy link
Copy Markdown
Contributor

PR description:

This PR updates the default model version for the L1TSC4NGJetModel from v0 to v1_0_1

Corresponding cms-hls4ml emulator: https://github.com/cms-hls4ml/L1TSC4NGJetModel

Corresponding PR to cms-dist: cms-sw/cmsdist#10485

This PR is for CMSSW 17 as this is the version after which the above cms-dist PR was merged into

Changes to the model inputs were made in this PR: #50174 which necessitated an update to the model

@cmsbuild
Copy link
Copy Markdown
Contributor

cmsbuild commented May 19, 2026

cms-bot internal usage

@cmsbuild
Copy link
Copy Markdown
Contributor

@cmsbuild
Copy link
Copy Markdown
Contributor

A new Pull Request was created by @Chriisbrown for master.

It involves the following packages:

  • L1Trigger/Phase2L1ParticleFlow (l1)

@BenjaminRS, @cmsbuild, @quinnanm can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol, @mmusich this is something you requested to watch as well.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@BenjaminRS
Copy link
Copy Markdown
Contributor

test parameters:

  • workflow = 29634.78
  • relvals_opt = --what upgrade

@BenjaminRS
Copy link
Copy Markdown
Contributor

please test

@cmsbuild
Copy link
Copy Markdown
Contributor

-1

Failed Tests: UnitTests RelVals
Size: This PR adds an extra 24KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b27932/53324/summary.html
COMMIT: a665cad
CMSSW: CMSSW_17_0_X_2026-05-18-2300/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/50975/53324/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b27932/53324/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b27932/53324/git-merge-result

Failed Unit Tests

I found 1 errors in the following unit tests:

---> test testProduceNanoHLT had ERRORS

Failed RelVals

----- Begin Fatal Exception 19-May-2026 15:28:20 CEST-----------------------
An exception of category 'FileInPathError' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing module: class=TrackstersProducer label='hltTiclTrackstersCLUE3DHigh'
Exception Message:
edm::FileInPath unable to find file RecoHGCal/TICL/data/ticlv5/onnx_models/CNN/patternrecognition/id_v0.onnx anywhere in the search path.
The search path is defined by: CMSSW_SEARCH_PATH
${CMSSW_SEARCH_PATH} is: /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/50975/53324/CMSSW_17_0_X_2026-05-18-2300/poison:/cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/50975/53324/CMSSW_17_0_X_2026-05-18-2300/src:/cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/50975/53324/CMSSW_17_0_X_2026-05-18-2300/external/el8_amd64_gcc13/data:/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02942/el8_amd64_gcc13/cms/cmssw/CMSSW_17_0_X_2026-05-18-2300/src:/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02942/el8_amd64_gcc13/cms/cmssw/CMSSW_17_0_X_2026-05-18-2300/external/el8_amd64_gcc13/data
Current directory is: /data/cmsbld/jenkins/workspace/ib-run-pr-relvals/matrix-results/34434.911_TTbar_14TeV+Run4D121_DD4hep
----- End Fatal Exception -------------------------------------------------
----- Begin Fatal Exception 19-May-2026 15:23:41 CEST-----------------------
An exception of category 'FileInPathError' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing module: class=TrackstersProducer label='hltTiclTrackstersCLUE3DHigh'
Exception Message:
edm::FileInPath unable to find file RecoHGCal/TICL/data/ticlv5/onnx_models/CNN/patternrecognition/id_v0.onnx anywhere in the search path.
The search path is defined by: CMSSW_SEARCH_PATH
${CMSSW_SEARCH_PATH} is: /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/50975/53324/CMSSW_17_0_X_2026-05-18-2300/poison:/cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/50975/53324/CMSSW_17_0_X_2026-05-18-2300/src:/cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/50975/53324/CMSSW_17_0_X_2026-05-18-2300/external/el8_amd64_gcc13/data:/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02942/el8_amd64_gcc13/cms/cmssw/CMSSW_17_0_X_2026-05-18-2300/src:/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02942/el8_amd64_gcc13/cms/cmssw/CMSSW_17_0_X_2026-05-18-2300/external/el8_amd64_gcc13/data
Current directory is: /data/cmsbld/jenkins/workspace/ib-run-pr-relvals/matrix-results/34434.0_TTbar_14TeV+Run4D121
----- End Fatal Exception -------------------------------------------------
----- Begin Fatal Exception 19-May-2026 15:24:07 CEST-----------------------
An exception of category 'FileInPathError' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing module: class=TrackstersProducer label='hltTiclTrackstersCLUE3DHigh'
Exception Message:
edm::FileInPath unable to find file RecoHGCal/TICL/data/ticlv5/onnx_models/CNN/patternrecognition/id_v0.onnx anywhere in the search path.
The search path is defined by: CMSSW_SEARCH_PATH
${CMSSW_SEARCH_PATH} is: /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/50975/53324/CMSSW_17_0_X_2026-05-18-2300/poison:/cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/50975/53324/CMSSW_17_0_X_2026-05-18-2300/src:/cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/50975/53324/CMSSW_17_0_X_2026-05-18-2300/external/el8_amd64_gcc13/data:/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02942/el8_amd64_gcc13/cms/cmssw/CMSSW_17_0_X_2026-05-18-2300/src:/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02942/el8_amd64_gcc13/cms/cmssw/CMSSW_17_0_X_2026-05-18-2300/external/el8_amd64_gcc13/data
Current directory is: /data/cmsbld/jenkins/workspace/ib-run-pr-relvals/matrix-results/34434.75_TTbar_14TeV+Run4D121_HLT75e33Timing
----- End Fatal Exception -------------------------------------------------
Expand to see more relval errors ...

@BenjaminRS
Copy link
Copy Markdown
Contributor

please test
errors seem to be coming from HGCAL HLT?

@mmusich
Copy link
Copy Markdown
Contributor

mmusich commented May 19, 2026

errors seem to be coming from HGCAL HLT?

I guess cms-data/RecoHGCal-TICL#12 didn't make the last build.

@cmsbuild
Copy link
Copy Markdown
Contributor

+1

Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b27932/53333/summary.html
COMMIT: a665cad
CMSSW: CMSSW_17_0_X_2026-05-19-1100/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/50975/53333/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 5 lines to the logs
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 54
  • DQMHistoTests: Total histograms compared: 4341706
  • DQMHistoTests: Total failures: 128
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 4341558
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 53 files compared)
  • Checked 232 log files, 201 edm output root files, 54 DQM output files
  • TriggerResults: no differences found

@BenjaminRS
Copy link
Copy Markdown
Contributor

+l1
I assume cms-data/RecoHGCal-TICL#12 was included in CMSSW_17_0_X_2026-05-19-1100, so the tests now pass

@cmsbuild
Copy link
Copy Markdown
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @mandrenguyen, @ftenchini, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Copy Markdown
Contributor

+1

@cmsbuild cmsbuild merged commit be7a514 into cms-sw:master May 20, 2026
11 checks passed
@Chriisbrown Chriisbrown deleted the L1TSC4NGJet_Update_version branch May 20, 2026 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants