Skip to content

DQM/SiTrackerPhase2: Streamline and clean up DQM code #50936

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cmsbuild merged 10 commits into from
May 19, 2026
Merged

DQM/SiTrackerPhase2: Streamline and clean up DQM code #50936

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
3c123f8
Replace manual iBooker1D/2D calls with phase2tkutil helpers, reduce f…
brandiskip May 11, 2026
685370a
Add declarations for add1DDesc and add2DDesc helper functions
brandiskip May 12, 2026
5fd9be0
Replace local helpers add1D and add2D with shared utility functions a…
brandiskip May 12, 2026
2ed6712
Add implementation for add1DDesc and add2DDesc helper functions
brandiskip May 12, 2026
93a1291
Simplify bookHistograms and fillDescriptions using shared utility fun…
brandiskip May 12, 2026
33611d0
Simplify bookHistograms and fillDescriptions using shared utility fun…
brandiskip May 12, 2026
5323619
Update config to use CMSSW_16_1_0_pre2 geometry and input file
brandiskip May 12, 2026
acd614b
update d0 hist range to match range found in Validation/Phase2OTValid…
brandiskip May 13, 2026
7b958cf
Merge remote-tracking branch 'my-cmssw/clean_up' into from-CMSSW_17_0…
brandiskip May 13, 2026
7ddae8d
changes from running code-checks and code-format
brandiskip May 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions DQM/SiTrackerPhase2/interface/TrackerPhase2DQMUtil.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
#define _DQM_SiTrackerPhase2_Phase2TrackerValidationUtil_h
#include "DataFormats/TrackerCommon/interface/TrackerTopology.h"
#include "FWCore/ParameterSet/interface/ParameterSet.h"
#include "FWCore/ParameterSet/interface/ParameterSetDescription.h"
#include "DQMServices/Core/interface/MonitorElement.h"
#include "DQMServices/Core/interface/DQMStore.h"
#include <string>
Expand All @@ -20,5 +21,26 @@ namespace phase2tkutil {
MonitorElement* book2DFromPSet(const edm::ParameterSet& hpars, DQMStore::IBooker& ibooker);

MonitorElement* bookProfile1DFromPSet(const edm::ParameterSet& hpars, DQMStore::IBooker& ibooker);

void add1DDesc(edm::ParameterSetDescription& desc,
const std::string& psetKey,
const std::string& histName,
const std::string& xlabel,
const std::string& ylabel,
int nbins,
double xmin,
double xmax);

void add2DDesc(edm::ParameterSetDescription& desc,
const std::string& psetKey,
const std::string& histName,
const std::string& xlabel,
const std::string& ylabel,
int nbx,
double xmin,
double xmax,
int nby,
double ymin,
double ymax);
} // namespace phase2tkutil
#endif
Loading