Skip to content

Phase2 HLT nano workflows: miscelleaneous fixes for TICL-related modules.#50748

Merged
cmsbuild merged 5 commits into
cms-sw:masterfrom
cms-ngt-hlt:mm_dev_nano_ticl_hlt_fixes
Apr 21, 2026
Merged

Phase2 HLT nano workflows: miscelleaneous fixes for TICL-related modules.#50748
cmsbuild merged 5 commits into
cms-sw:masterfrom
cms-ngt-hlt:mm_dev_nano_ticl_hlt_fixes

Conversation

@mmusich
Copy link
Copy Markdown
Contributor

@mmusich mmusich commented Apr 17, 2026

PR description:

It was noticed by @elenavernazza that:

  • we are not running any workflow in the ph2_hlt matrix to exercise the @Phase2HLTVal flavour
  • when running workflow in which the VALIDATION step is not explicited in the cmsDriver the setup crashes on missing input on various TICL-related modules.

The goal for this PR is:

  • to include a new workflow family .0.7591 that exercises the @Phase2HLTVal nano flavour
  • to implement in all the modules that didn't have a protection again missing input, such protection, profiting of the existing skipNonExistingSrc mechanism in the base classes

I profit of this PR to include commit cms-ngt-hlt@bcc2972 to improve the readability of HLTrigger/NGTScouting/python/hltTracksters_cfi.py

PR validation:

I've run successfully the following workflow:

runTheMatrix.py -l 34434.7591 -t 4 -j 8

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Not a backport, will not be backported.

Cc: @waredjeb

@cmsbuild
Copy link
Copy Markdown
Contributor

cmsbuild commented Apr 17, 2026

cms-bot internal usage

@mmusich
Copy link
Copy Markdown
Contributor Author

mmusich commented Apr 17, 2026

test parameters:

  • workflows = ph2_hlt

@cmsbuild
Copy link
Copy Markdown
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-50748/49037

@cmsbuild
Copy link
Copy Markdown
Contributor

A new Pull Request was created by @mmusich for master.

It involves the following packages:

  • Configuration/PyReleaseValidation (pdmv)
  • HLTrigger/NGTScouting (hlt)
  • PhysicsTools/NanoAOD (xpog)

@AdrianoDee, @DickyChant, @Martin-Grunewald, @antoniovagnerini, @battibass, @cmsbuild, @ftorrresd, @miquork, @mmusich can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @fabiocos, @gpetruc, @makortel, @missirol, @slomeo this is something you requested to watch as well.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Copy Markdown
Contributor Author

mmusich commented Apr 17, 2026

@cmsbuild, please test

@mmusich
Copy link
Copy Markdown
Contributor Author

mmusich commented Apr 17, 2026

type ngt

@cmsbuild
Copy link
Copy Markdown
Contributor

+1

Size: This PR adds an extra 68KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-de7072/52721/summary.html
COMMIT: bcc2972
CMSSW: CMSSW_17_0_X_2026-04-17-1100/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/50748/52721/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 1 lines from the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 10 differences found in the comparisons
  • DQMHistoTests: Total files compared: 66
  • DQMHistoTests: Total histograms compared: 4568057
  • DQMHistoTests: Total failures: 47
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 4567990
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 65 files compared)
  • Checked 274 log files, 233 edm output root files, 66 DQM output files
  • TriggerResults: found differences in 1 / 64 workflows

@ftorrresd
Copy link
Copy Markdown
Contributor

enable nano

@ftorrresd
Copy link
Copy Markdown
Contributor

please test

@cmsbuild
Copy link
Copy Markdown
Contributor

+1

Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-de7072/52737/summary.html
COMMIT: bcc2972
CMSSW: CMSSW_17_0_X_2026-04-18-1100/el8_amd64_gcc13
Additional Tests: NANO
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/50748/52737/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 1 lines to the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 6 differences found in the comparisons
  • DQMHistoTests: Total files compared: 66
  • DQMHistoTests: Total histograms compared: 4569267
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 4569244
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 65 files compared)
  • Checked 274 log files, 233 edm output root files, 66 DQM output files
  • TriggerResults: no differences found

Nano size comparison Summary:

workflow id kb/ev ref kb/ev diff kb/ev ev/s/thd ref ev/s/thd diff rate mem/thd ref mem/thd
NANOmc106Xul16v2 2500.0001 3.094 3.094 0.000 ( +0.0% ) 3.75 3.45 +8.8% 2.615 2.680
NANOmc106Xul16APVv2 2500.0002 3.048 3.048 0.000 ( +0.0% ) 3.71 3.51 +5.8% 2.668 2.707
NANOmc106Xul17v2 2500.0003 3.153 3.153 0.000 ( +0.0% ) 3.51 3.26 +7.6% 3.063 3.126
NANOmc106Xul18v2 2500.0004 3.105 3.105 0.000 ( +0.0% ) 3.51 3.27 +7.3% 3.039 3.120
NANOdata106Xul16v2 2500.0101 1.540 1.540 0.000 ( +0.0% ) 6.23 5.69 +9.4% 2.723 2.787
NANOdata106Xul17v2 2500.0102 1.926 1.926 0.000 ( +0.0% ) 4.15 3.87 +7.4% 2.947 2.955
NANOdata106Xul18v2 2500.0103 1.890 1.890 0.000 ( +0.0% ) 4.98 4.63 +7.7% 2.827 2.840
NANOmcUL16APVreMINI 2500.0201 0.022 0.022 0.000 ( +0.0% ) 1.86 1.80 +3.5% 2.618 2.645
NANOmcUL16reMINI 2500.0202 0.022 0.022 0.000 ( +0.0% ) 1.78 1.74 +2.3% 2.668 2.659
NANOmcUL17reMINI 2500.0203 0.022 0.022 0.000 ( +0.0% ) 1.64 1.62 +0.7% 2.759 2.897
NANOmcUL18reMINI 2500.0204 0.022 0.022 0.000 ( +0.0% ) 1.59 1.58 +0.4% 2.779 2.787
NANOdataUL16APVreMINI 2500.0301 0.035 0.035 0.000 ( +0.0% ) 1.59 1.53 +3.9% 2.650 2.705
NANOdataUL16reMINI 2500.0302 0.036 0.036 0.000 ( +0.0% ) 1.58 1.54 +2.9% 2.591 2.627
NANOdataUL17reMINI 2500.0303 0.037 0.037 0.000 ( +0.0% ) 1.54 1.51 +2.3% 2.715 2.725
NANOdataUL18reMINI 2500.0304 0.036 0.036 0.000 ( +0.0% ) 1.53 1.49 +2.9% 2.701 2.713
NANOmcUL16APVMini2Mini 2500.0401 0.023 0.023 0.000 ( +0.0% ) 2.59 2.56 +1.2% 2.133 2.230
NANOmcUL16Mini2Mini 2500.0402 0.023 0.023 0.000 ( +0.0% ) 2.46 2.40 +2.8% 2.114 2.155
NANOmcUL17Mini2Mini 2500.0403 0.023 0.023 0.000 ( +0.0% ) 2.39 2.24 +6.6% 2.131 2.171
NANOmcUL18Mini2Mini 2500.0404 0.023 0.023 0.000 ( +0.0% ) 2.40 2.31 +4.0% 2.148 2.167
NANOdataUL16Mini2Mini 2500.0501 0.039 0.039 0.000 ( +0.0% ) 3.45 3.41 +1.2% 2.001 2.014
NANOdataUL17Mini2Mini 2500.0502 0.040 0.040 0.000 ( +0.0% ) 2.59 2.53 +2.3% 2.055 2.067
NANOdataUL18Mini2Mini 2500.0503 0.039 0.039 0.000 ( +0.0% ) 2.93 2.94 -0.2% 2.076 2.063
NANOmc130X 2500.1001 3.228 3.228 0.000 ( +0.0% ) 4.24 3.74 +13.4% 2.987 3.006
NANOdata130Xrun3 2500.1101 1.790 1.790 0.000 ( +0.0% ) 6.43 5.90 +9.1% 2.707 2.706
NANOmc23Mini2Mini 2500.1201 0.022 0.022 0.000 ( +0.0% ) 2.60 2.66 -2.2% 2.008 2.011
NANOdata23Mini2Mini 2500.1301 0.041 0.041 0.000 ( +0.0% ) 3.56 3.58 -0.7% 2.306 2.328
ScoutingNANOdata124Xrun3 2500.1501 0.772 0.772 0.000 ( +0.0% ) 34.21 33.58 +1.9% 1.486 1.496
ScoutingNANOmonitordata124Xrun3 2500.1502 0.862 0.862 0.000 ( +0.0% ) 12.67 12.92 -1.9% 1.398 1.464
ScoutingNANOdata130Xrun3 2500.1503 1.251 1.251 0.000 ( +0.0% ) 25.15 24.26 +3.7% 1.461 1.463
ScoutingNANOmonitordata130Xrun3 2500.1504 1.297 1.297 0.000 ( +0.0% ) 11.08 10.48 +5.7% 1.396 1.391
muPOGNANOmc140X 2500.2201 2.269 2.269 0.000 ( +0.0% ) 5.57 5.44 +2.3% 2.083 2.129
EGMNANOmc140X 2500.2202 3.859 3.859 0.000 ( +0.0% ) 4.03 3.86 +4.5% 2.416 2.449
BTVNANOmc140X 2500.2203 10.475 10.475 0.000 ( +0.0% ) 2.57 2.47 +4.0% 2.601 2.610
jmeNANOmc140X 2500.2204 6.639 6.639 0.000 ( +0.0% ) 1.14 1.04 +10.5% 2.503 2.544
lepTrackInfoNANOmc140X 2500.2206 3.553 3.553 0.000 ( +0.0% ) 4.01 3.77 +6.5% 2.422 2.419
ScoutingNANOmc140X 2500.2207 1.488 1.488 0.000 ( +0.0% ) 14.24 13.00 +9.6% 1.789 1.800
ScoutingNANOwithPromptmc140X 2500.2208 4.461 4.461 0.000 ( +0.0% ) 3.19 2.97 +7.3% 2.715 2.733
muPOGNANO140Xrun3 2500.2301 1.683 1.683 0.000 ( +0.0% ) 7.75 6.94 +11.8% 2.336 2.347
EGMNANOdata140Xrun3 2500.2302 2.623 2.623 0.000 ( +0.0% ) 5.81 5.23 +11.1% 2.672 2.682
BTVNANOdata140Xrun3 2500.2303 5.612 5.612 0.000 ( +0.0% ) 3.72 3.28 +13.4% 2.850 2.861
jmeNANOdata140Xrun3 2500.2304 3.976 3.976 0.000 ( +0.0% ) 1.49 1.29 +15.8% 2.736 2.772
lepTrackInfoNANOdata140Xrun3 2500.2306 2.413 2.413 0.000 ( +0.0% ) 5.83 5.16 +12.9% 2.672 2.669
ScoutingNANOdata140Xrun3 2500.2307 1.101 1.101 0.000 ( +0.0% ) 30.07 27.42 +9.7% 1.458 1.463
ScoutingNANOmonitordata140Xrun3 2500.2308 2.784 2.784 0.000 ( +0.0% ) 5.08 4.70 +8.1% 2.925 2.926
ScoutingNANOmonitorWithPromptdata140Xrun3 2500.2309 2.784 2.784 0.000 ( +0.0% ) 5.10 4.70 +8.4% 2.931 2.947
L1ScoutingSelectionNANOdata140Xrun3 2500.2311 0.081 0.081 0.000 ( +0.0% ) 47.67 44.13 +8.0% 0.696 0.734
L1ScoutingNANOdata140Xrun3 2500.231 0.082 0.082 0.000 ( +0.0% ) 4.12 3.79 +8.9% 0.837 0.834
l1DPGNANO140Xrun3 2500.2401 9.405 9.405 0.000 ( +0.0% ) 7.54 7.17 +5.1% 1.721 1.743
muDPGNANO140Xrun3 2500.2402 10.377 10.377 0.000 ( +0.0% ) 1.65 1.46 +13.1% 1.592 1.618
muDPGNANOBkg140Xrun3 2500.2403 6.401 6.401 0.000 ( +0.0% ) 15.85 14.30 +10.8% 1.196 1.197
hcalDPGNANO140Xrun3 2500.2404 486.015 486.015 0.000 ( +0.0% ) 1.16 1.10 +4.9% 1.584 1.589
hcalDPGCalibNANO140Xrun3 2500.2405 826.418 826.418 0.000 ( +0.0% ) 1.53 1.43 +7.0% 1.587 1.594
hcalDPGMCNANO140Xrun3 2500.2501 645.333 645.333 0.000 ( +0.0% ) 1.65 1.56 +6.4% 1.684 1.692
NANOmc2024reMINI 2500.2601 0.021 0.021 0.000 ( +0.0% ) 1.92 1.76 +9.0% 2.666 2.672
NANOdata2024reMINI 2500.2701 0.036 0.036 0.000 ( +0.0% ) 1.92 1.76 +9.2% 2.608 2.634
NANOmc150X 2500.3001 3.224 3.224 0.000 ( +0.0% ) 17.98 16.77 +7.2% 2.574 2.650
NANOdata150X 2500.3101 2.144 2.144 0.000 ( +0.0% ) 34.60 30.28 +14.3% 2.268 2.276
NANOdata150X 2500.3102 2.630 2.630 0.000 ( +0.0% ) 27.93 25.36 +10.1% 2.288 2.462
muPOGNANOmc150X 2500.3201 2.344 2.344 0.000 ( +0.0% ) 16.42 15.23 +7.9% 2.402 2.397
EGMNANOmc150X 2500.3202 4.118 4.118 0.000 ( +0.0% ) 14.76 13.67 +8.0% 2.511 2.507
BTVNANOmc150X 2500.3203 10.559 10.559 0.000 ( +0.0% ) 4.93 4.61 +6.9% 2.715 2.710
jmeNANOmc150X 2500.3204 6.460 6.460 0.000 ( +0.0% ) 1.36 1.28 +6.9% 2.691 2.684
jmeNANOrePuppimc150X 2500.3205 6.464 6.464 0.000 ( +0.0% ) 1.28 1.21 +6.2% 2.995 3.000
lepTrackInfoNANOmc150X 2500.3206 3.728 3.728 0.000 ( +0.0% ) 15.25 14.35 +6.3% 2.519 2.533
ScoutingNANOmc150X 2500.3207 1.563 1.563 0.000 ( +0.0% ) 20.00 19.46 +2.8% 2.257 2.243
ScoutingNANOwithPromptmc150X 2500.3208 4.781 4.781 0.000 ( +0.0% ) 10.59 10.09 +5.0% 2.696 2.690
BPHNANOmc150X 2500.3209 4.135 4.135 0.000 ( +0.0% ) 17.12 16.23 +5.4% 2.598 2.796
muPOGNANO150Xrun3 2500.3301 1.244 1.244 0.000 ( +0.0% ) 29.57 27.41 +7.9% 2.118 2.133
EGMNANOdata150Xrun3 2500.3302 2.985 2.985 0.000 ( +0.0% ) 26.68 24.96 +6.9% 2.190 2.192
BTVNANOdata150Xrun3 2500.3303 7.971 7.971 0.000 ( +0.0% ) 6.03 5.86 +2.9% 2.391 2.604
jmeNANOdata150Xrun3 2500.3304 4.349 4.349 0.000 ( +0.0% ) 1.68 1.55 +8.2% 2.383 2.417
jmeNANOrePuppidata150Xrun3 2500.3305 4.332 4.332 0.000 ( +0.0% ) 1.45 1.36 +6.5% 2.648 2.644
lepTrackInfoNANOdata150Xrun3 2500.3306 2.625 2.625 0.000 ( +0.0% ) 28.21 26.84 +5.1% 2.186 2.232
ScoutingNANOdata150Xrun3 2500.3307 1.738 1.738 0.000 ( +0.0% ) 32.04 31.02 +3.3% 1.511 1.507
ScoutingNANOmonitordata150Xrun3 2500.3308 1.400 1.400 0.000 ( +0.0% ) 27.60 26.45 +4.3% 2.104 2.135
ScoutingNANOmonitorWithPromptdata150Xrun3 2500.3309 2.602 2.602 0.000 ( +0.0% ) 18.18 16.90 +7.6% 2.470 2.506
L1ScoutingNANOdata150Xrun3 2500.3311 0.078 0.078 0.000 ( +0.0% ) 3.55 3.38 +4.9% 0.901 0.960
L1ScoutingSelectionNANOdata150Xrun3 2500.3312 0.078 0.078 0.000 ( +0.0% ) 26.79 26.02 +3.0% 0.856 0.960
BPHNANOdata150Xrun3 2500.331 2.632 2.632 0.000 ( +0.0% ) 32.36 30.96 +4.5% 2.305 2.311
L1ScoutingNANOdata160Xrun3 2500.4301 0.110 0.110 0.000 ( +0.0% ) 2.13 2.06 +3.5% 0.848 0.939
L1ScoutingSelectionNANOdata160Xrun3 2500.4302 0.113 0.113 0.000 ( +0.0% ) 19.22 18.89 +1.8% 0.855 0.970
TTbarMINIAOD10.6_UL18v2 2500.9001 1.814 1.814 0.000 ( +0.0% ) 34.66 34.75 -0.3% 1.823 1.843
TTbarMINIAOD14.0 2500.9002 1.662 1.662 0.000 ( +0.0% ) 33.85 33.08 +2.3% 1.459 1.460
DYToLL_M-50_13TeV_pythia8 2500.9101 14.992 14.992 0.000 ( +0.0% ) 8.04 6.87 +17.1% 1.114 1.162
DYToll01234Jets_5f_LO_MLM_Madgraph_LHE_13TeV 2500.9102 0.199 0.171 0.029 ( +16.9% ) 2.58 2.45 +5.5% 0.899 0.899
TTbar_Pow_LHE_13TeV 2500.9103 0.110 0.110 0.000 ( +0.0% ) 2.48 2.10 +17.9% 0.904 0.899

NANO Comparison Summary

Summary:

  • You potentially removed 482 lines from the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 32
  • DQMHistoTests: Total histograms compared: 43020
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 43020
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
  • Checked 189 log files, 110 edm output root files, 32 DQM output files
  • TriggerResults: no differences found

@mmusich
Copy link
Copy Markdown
Contributor Author

mmusich commented Apr 19, 2026

+hlt

@battibass
Copy link
Copy Markdown

+xpog

@mmusich
Copy link
Copy Markdown
Contributor Author

mmusich commented Apr 20, 2026

@cms-sw/pdmv-l2 kind ping

@antoniovagnerini
Copy link
Copy Markdown

+pdmv

@cmsbuild
Copy link
Copy Markdown
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @ftenchini, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Copy Markdown
Contributor

+1

@cmsbuild cmsbuild merged commit 901a072 into cms-sw:master Apr 21, 2026
13 checks passed
@mmusich mmusich deleted the mm_dev_nano_ticl_hlt_fixes branch April 21, 2026 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants