Rpc digi dev v9 by bapavlov · Pull Request #47447 · cms-sw/cmssw

bapavlov · 2025-02-25T13:07:03Z

PR description:

We would like to introduce some new code for the RPC Phase 2 upgrade.
So far, the digitization for both the currently installed RPCs and the ones planned for the Phase 2 upgrade have used the same data format, which was developed for the Muon upgrade TDR. However, this format is no longer adequate due to the changes planned for the RPC Phase 2 upgrade.
In short, the RPC Phase 2 upgrade includes two major changes:

Improved readout electronics for all currently installed RPCs, allowing for more precise timing measurements.
Installation of a new type of RPCs, called iRPCs (an abbreviation for “improved RPC”), in the endcap stations RE3/1 and RE4/1.

We would like to introduce these changes into the software as well. We will keep the current digi format intact, but we plan to add two additional digi formats, called RPCDigiPhase2 and IRPCDigi. Below is a brief description of the proposed changes:

The readout of signals from all existing RPCs will be modified. Currently, the signal is digitized with a 40 MHz clock, corresponding to exactly 1 Bunch Crossing (BX) or a 25 ns time interval. After the Phase 2 upgrade, the RPCs will be read out with a much finer clock, allowing for sub-BX resolution. Thus, we aim to add a new data format for the RPC Phase 2 upgrade that enables sub-BX resolution. The new digi format is DataFormats/RPCDigi/interface/RPCDigiPhase2.h
In addition, the new iRPCs (improved RPCs) will be introduced in the CMS endcaps. The major difference between RPCs and iRPCs is that iRPC strips will be read out from both ends, allowing precise estimation of the muon impact point on the strip and very accurate time measurement. We have also prepared a new format for iRPCs, and the code DataFormats/IRPCDigi
We will keep the current digitization code intact, but we would like to add a digitization code for the Phase 2 RPC upgrade and iRPCs. The code is available here SimMuon/RPCDigitizer

PR validation:

At the moment, our colleagues are using the code from my repository and are developing the code for the next steps (e.g., trigger emulators). The code is tested and works as expected. Results have been reported during several RPC DPG and RPC Trigger meetings:
RPC DPG May 8, 2024
RPC Trigger Oct 2, 2024
RPC DPG Jan 22, 2025
RPC DPG Feb 5, 2025

I would like to emphasize again that we have taken special care not to interfere with the present simulation in any way.

cmsbuild · 2025-02-25T13:07:32Z

cms-bot internal usage

cmsbuild · 2025-02-25T13:10:30Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47447/43859

Code check has found code style and quality issues which could be resolved by applying following patch(s)

code-format:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47447/43859/code-format.patch
e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47447/43859/code-format.patch | patch -p1
You can also run scram build code-format to apply code format directly

cmsbuild · 2025-02-25T22:18:11Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47447/43875

cmsbuild · 2025-02-25T22:18:35Z

A new Pull Request was created by @bapavlov for master.

It involves the following packages:

DataFormats/IRPCDigi (****)
DataFormats/RPCDigi (simulation)
IOMC/RandomEngine (core)
SimMuon/Configuration (simulation)
SimMuon/RPCDigitizer (simulation)

The following packages do not have a category, yet:

DataFormats/IRPCDigi
Please create a PR for https://github.com/cms-sw/cms-bot/blob/master/categories_map.py to assign category

@Dr15Jones, @civanch, @cmsbuild, @kpedro88, @makortel, @mdhildreth, @smuzaffar can you please review it and eventually sign? Thanks.
@CeliaFernandez, @Fedespring, @HuguesBrun, @abbiendi, @andrea21z, @battibass, @cericeci, @fabiocos, @giovanni-mocellin, @jhgoh, @makortel, @missirol, @mmusich, @rovere, @slomeo, @trocino, @wddgit this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

kpedro88 · 2025-02-25T22:22:18Z

@bapavlov some initial questions/comments:

Please create a companion PR to https://github.com/cms-sw/cms-bot to add your new package to categories_map.py
Is there a workflow that executes this code? If not, please add one for testing purposes.

civanch · 2025-02-26T10:37:01Z

@bapavlov , @kpedro88 , I would propose do not create IRPCDigi directory. I may be wrong but in a long term it will create more problems than benefits. At least, please, consider this option.

kpedro88 · 2025-02-26T14:26:42Z

I have no strong opinion about the new package either way. To me, it is up to the DPG to decide how they want to organize their code at this level. That said, my detailed code review is waiting on responses to the initial questions above.

kpedro88 · 2025-03-03T18:02:28Z

@bapavlov just to be clear, I am waiting on your replies to #47447 (comment) before further review or testing.

bapavlov · 2025-03-03T20:26:50Z

@kpedro88, @civanch We discussed your comments #47447 (comment) within the RPC group and decided to follow Vladimir's suggestion to move IRPCDigi to the DataFormats/RPCDigi directory. I assume that, in this case, there is no need of a companion PR to https://github.com/cms-sw/cms-bot.

Regarding your question about the workflow: currently, only the DIGI step for RPCPhase2 and IRPC is implemented, and no dedicated workflow is included yet. I have a technical question about how to proceed with implementing the workflow.

Should I create a new Era to include this workflow, or is there another recommended approach?
What should the workflow consist of? Should it also include the RECO step?

Your guidance on this would be greatly appreciated.

kpedro88 · 2025-03-03T20:38:40Z

@bapavlov indeed, if there is no new package, then no PR to cms-bot is needed.

For now, you should create a new Modifier to enable this change in the DIGI step. Then you can add a special workflow, as documented at https://github.com/cms-sw/cmssw/tree/master/Configuration/PyReleaseValidation. You can follow the phase2_ecal_devel example, which is very similar to yours; they also have removed downstream steps from the special workflow until the development advances and they are ready to run those steps again.

cmsbuild · 2025-03-03T20:54:31Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47447/43939

Found files with invalid states:
- DataFormats/IRPCDigi/BuildFile.xml:
  - Added: 7b32d20
  - Deleted: 4f66246
- DataFormats/IRPCDigi/src/classes_def.xml:
  - Added: 7b32d20
  - Deleted: 4f66246
- DataFormats/IRPCDigi/src/IRPCDigi.cc:
  - Added: 7b32d20
  - Modified: 2c99471
  - Deleted: 4f66246
- DataFormats/IRPCDigi/src/classes_def.xml.generated:
  - Added: 7b32d20
  - Deleted: 4f66246
- DataFormats/IRPCDigi/src/classes.h:
  - Added: 7b32d20
  - Deleted: 4f66246
- DataFormats/IRPCDigi/interface/IRPCDigi.h:
  - Added: 7b32d20
  - Modified: 2c99471
  - Deleted: 4f66246
- DataFormats/IRPCDigi/interface/IRPCDigiCollection.h:
  - Added: 7b32d20
  - Deleted: 4f66246
- DataFormats/IRPCDigi/src/IRPCDigiTime.cc:
  - Added: 7b32d20
  - Modified: 2c99471
  - Deleted: 4f66246
- DataFormats/IRPCDigi/doc/RPCDigi.doc:
  - Added: 7b32d20
  - Deleted: 4f66246
- DataFormats/IRPCDigi/interface/IRPCDigiTime.h:
  - Added: 7b32d20
  - Modified: 2c99471
  - Deleted: 4f66246

civanch · 2026-04-18T12:36:45Z

@cms-sw/core-l2, @cms-sw/pdmv-l2, this old PR seems to be ready. The upgrade cannot sign any more, so @cms-sw/orp-l2 please ignore upgrade.

Co-authored-by: Matti Kortelainen <matti.kortelainen@cern.ch>

cmsbuild · 2026-04-20T13:39:37Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47447/49076

There are other open Pull requests which might conflict with changes you have proposed:
- File Configuration/PyReleaseValidation/python/upgradeWorkflowComponents.py modified in PR(s): update phase-2 HLT timing script and use alpaka modifier in NGT workflows #49821, TICL: Consolidate v5 as Default Configuration and Cleanup Legacy Code #49932, MLPF Run 3 inference code and model update #50316, Phase2 HLT nano workflows: miscelleaneous fixes for TICL-related modules. #50748

cmsbuild · 2026-04-20T13:40:00Z

Pull request #47447 was updated. @AdrianoDee, @DickyChant, @Dr15Jones, @antoniovagnerini, @civanch, @cmsbuild, @davidlange6, @fabiocos, @ftenchini, @kpedro88, @makortel, @mandrenguyen, @mdhildreth, @miquork, @smuzaffar can you please check and sign again.

makortel · 2026-04-20T14:05:53Z

@cmsbuild, please test

cmsbuild · 2026-04-20T16:32:26Z

-1

Failed Tests: RelVals-INPUT
Size: This PR adds an extra 24KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4e2202/52774/summary.html
COMMIT: 526f678
CMSSW: CMSSW_17_0_X_2026-04-20-1100/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/47447/52774/install.sh to create a dev area with all the needed externals and cmssw changes.

Failed RelVals-INPUT

136.897DAS Error

Comparison Summary

Summary:

You potentially added 2 lines to the logs
ROOTFileChecks: Some differences in event products or their sizes found
Reco comparison results: 499 differences found in the comparisons
DQMHistoTests: Total files compared: 53
DQMHistoTests: Total histograms compared: 4186853
DQMHistoTests: Total failures: 37
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 4186796
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 52 files compared)
Checked 227 log files, 197 edm output root files, 53 DQM output files
TriggerResults: no differences found

makortel · 2026-04-20T17:46:10Z

+core

The core parts are fine (thanks for the ping)

civanch · 2026-04-21T02:23:51Z

+1

mandrenguyen · 2026-04-21T15:24:38Z

ignore tests-rejected with manual-override

mandrenguyen · 2026-04-21T15:25:37Z

@cms-sw/pdmv-l2 kindly have a look. It's just you left, since upgrade doesn't exist anymore.

bapavlov · 2026-05-05T12:39:57Z

I just wanted to kindly ask if there is any update on the PR, or an estimate of when it might be merged?

AdrianoDee · 2026-05-05T13:25:26Z

test parameters:

addpkg = SimG4Core/CustomPhysics
relval_opt = -w upgrade
workflow = 34434.62

AdrianoDee · 2026-05-05T13:25:55Z

please test
(it seems to me the new wf was never actually tested)

cmsbuild · 2026-05-05T15:45:03Z

+1

Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4e2202/53078/summary.html
COMMIT: 526f678
CMSSW: CMSSW_17_0_X_2026-05-05-1100/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/47447/53078/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially added 1 lines to the logs
ROOTFileChecks: Some differences in event products or their sizes found
Reco comparison results: 321 differences found in the comparisons
DQMHistoTests: Total files compared: 53
DQMHistoTests: Total histograms compared: 4187168
DQMHistoTests: Total failures: 582
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 4186566
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 52 files compared)
Checked 227 log files, 197 edm output root files, 53 DQM output files
TriggerResults: no differences found

AdrianoDee · 2026-05-05T15:58:33Z

+pdmv

kpedro88 · 2026-05-13T14:25:01Z

@bapavlov this needs to be rebased. (sorry! likely caused by #50886)

kpedro88 · 2026-05-13T14:25:08Z

unassign upgrade

cmsbuild · 2026-05-13T16:50:18Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47447/49336

ERROR: Build errors found during clang-tidy run.

      |   crossingFrameTokens
--
src/SimMuon/RPCDigitizer/src/RPCDigiProducer.cc:58:22: error: no viable overloaded '=' [clang-diagnostic-error]
   58 |   crossingFrameToken = consumes<CrossingFrame<PSimHit>>(edm::InputTag(mix_, collection_for_XF));
      |   ~~~~~~~~~~~~~~~~~~ ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02941/el8_amd64_gcc13/external/gcc/13.4.0-6908cfdf803923e783448096ca4f0923/lib/gcc/x86_64-redhat-linux-gnu/13.4.0/../../../../include/c++/13.4.0/bits/stl_vector.h:751:7: note: candidate function not viable: no known conversion from 'EDGetTokenT<CrossingFrame<PSimHit>>' to 'const vector<edm::EDGetTokenT<CrossingFrame<PSimHit>>>' for 1st argument
--
src/SimMuon/RPCDigitizer/src/RPCDigiProducer.cc:58:57: error: no matching constructor for initialization of 'edm::InputTag' [clang-diagnostic-error]
   58 |   crossingFrameToken = consumes<CrossingFrame<PSimHit>>(edm::InputTag(mix_, collection_for_XF));
      |                                                         ^             ~~~~~~~~~~~~~~~~~~~~~~~
/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02941/el8_amd64_gcc13/cms/cmssw/CMSSW_17_0_X_2026-05-13-1100/src/FWCore/Utilities/interface/InputTag.h:15:5: note: candidate constructor not viable: no known conversion from 'const std::set<std::string>' (aka 'const set<basic_string<char>>') to 'const std::string' (aka 'const basic_string<char>') for 2nd argument
--
src/SimMuon/RPCDigitizer/src/RPCDigiProducer.cc:58:71: error: use of undeclared identifier 'mix_'; did you mean 'mix'? [clang-diagnostic-error]
   58 |   crossingFrameToken = consumes<CrossingFrame<PSimHit>>(edm::InputTag(mix_, collection_for_XF));
      |                                                                       ^~~~
      |                                                                       mix
--
src/SimMuon/RPCDigitizer/src/RPCDigiProducer.cc:58:77: error: use of undeclared identifier 'collection_for_XF'; did you mean 'collections_for_XF'? [clang-diagnostic-error]
   58 |   crossingFrameToken = consumes<CrossingFrame<PSimHit>>(edm::InputTag(mix_, collection_for_XF));
      |                                                                             ^~~~~~~~~~~~~~~~~
      |                                                                             collections_for_XF
--
gmake: *** [config/SCRAM/GMake/Makefile.coderules:129: code-checks] Error 2
gmake: *** [There are compilation/build errors. Please see the detail log above.] Error 2

kpedro88 · 2026-05-13T16:55:18Z

@bapavlov please consult the changes at https://github.com/cms-sw/cmssw/pull/50886/changes#diff-6bd7598a7b8f0244909bffa30f3e7f7024101268c2986aa5bd32d93715dab15d to see how to update this PR correctly. (also, rebase is preferred rather than merge; see tutorial)

bapavlov · 2026-05-13T17:58:30Z

@kpedro88 I removed the merge and will follow the instructions to rebase the code

cmsbuild added this to the CMSSW_15_1_X milestone Feb 25, 2025

cmsbuild added simulation-pending core-pending pending-signatures tests-pending orp-pending new-package-pending code-checks-pending changes-dataformats labels Feb 25, 2025

cmsbuild added code-checks-rejected code-checks-pending and removed code-checks-pending code-checks-rejected labels Feb 25, 2025

cmsbuild added code-checks-approved and removed code-checks-pending labels Feb 25, 2025

cmsbuild added code-checks-pending and removed new-package-pending code-checks-approved labels Mar 3, 2025

cmsbuild removed the code-checks-pending label Mar 3, 2025

cmsbuild mentioned this pull request Apr 17, 2026

Phase2 HLT nano workflows: miscelleaneous fixes for TICL-related modules. #50748

Merged

makortel reviewed Apr 20, 2026

View reviewed changes

Comment thread DataFormats/RPCDigi/src/classes_def.xml Outdated

Comment thread DataFormats/RPCDigi/src/classes_def.xml Outdated

bapavlov and others added 2 commits April 20, 2026 16:37

Update DataFormats/RPCDigi/src/classes_def.xml

1b00692

Co-authored-by: Matti Kortelainen <matti.kortelainen@cern.ch>

Update DataFormats/RPCDigi/src/classes_def.xml

526f678

Co-authored-by: Matti Kortelainen <matti.kortelainen@cern.ch>

This was referenced May 5, 2026

Sync FASTPU_X changes in to main CMSSW #50886

Merged

Uniform vertex distribution in a R and ϕ range. #50904

Merged

Conversation

bapavlov commented Feb 25, 2025

PR description:

PR validation:

Uh oh!

cmsbuild commented Feb 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cmsbuild commented Feb 25, 2025

Uh oh!

cmsbuild commented Feb 25, 2025

Uh oh!

cmsbuild commented Feb 25, 2025

Uh oh!

kpedro88 commented Feb 25, 2025

Uh oh!

civanch commented Feb 26, 2025

Uh oh!

kpedro88 commented Feb 26, 2025

Uh oh!

kpedro88 commented Mar 3, 2025

Uh oh!

bapavlov commented Mar 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kpedro88 commented Mar 3, 2025

Uh oh!

cmsbuild commented Mar 3, 2025

Uh oh!

civanch commented Apr 18, 2026

Uh oh!

Uh oh!

Uh oh!

cmsbuild commented Apr 20, 2026

Uh oh!

cmsbuild commented Apr 20, 2026

Uh oh!

makortel commented Apr 20, 2026

Uh oh!

cmsbuild commented Apr 20, 2026

Failed RelVals-INPUT

Comparison Summary

Uh oh!

makortel commented Apr 20, 2026

Uh oh!

civanch commented Apr 21, 2026

Uh oh!

mandrenguyen commented Apr 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mandrenguyen commented Apr 21, 2026

Uh oh!

bapavlov commented May 5, 2026

Uh oh!

AdrianoDee commented May 5, 2026

Uh oh!

AdrianoDee commented May 5, 2026

Uh oh!

cmsbuild commented May 5, 2026

Comparison Summary

Uh oh!

AdrianoDee commented May 5, 2026 via email

Uh oh!

kpedro88 commented May 13, 2026

Uh oh!

kpedro88 commented May 13, 2026

Uh oh!

cmsbuild commented May 13, 2026

Uh oh!

kpedro88 commented May 13, 2026

Uh oh!

bapavlov commented May 13, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

cmsbuild commented Feb 25, 2025 •

edited

Loading

bapavlov commented Mar 3, 2025 •

edited

Loading

mandrenguyen commented Apr 21, 2026 •

edited

Loading