Improve handling of missing/invalid inputs in `TrackingAssocValueMapsProducer` by Parsifal-2045 · Pull Request #50730 · cms-sw/cmssw

Parsifal-2045 · 2026-04-15T14:55:03Z

PR description:

This PR fixes the incorrect handling of missing/invalid inputs in TrackingAssocValueMapsProducer.
@elenavernazza (thank you!) found out that when running the NanoPixelTables sequence without the Validation step, the job would crash with

----- Begin Fatal Exception 15-Apr-2026 15:01:50 CEST-----------------------
An exception of category 'InvalidReference' occurred while
   [0] Processing  Event run: 1 lumi: 1 event: 3 stream: 0
   [1] Running path 'nanoAOD_step'
   [2] Calling method for module SimpleTriggerTrackFlatTableProducer/'hltPixelTrackTable'
Exception Message:
ValueMap: no associated value for given product and index
----- End Fatal Exception -------------------------------------------------

This happens because the associator required by TrackingAssocValueMapsProducer is only produced on the fly in the validation sequence. However, the module should simply return empty valueMaps in these cases, which it now correctly does.

PR validation:

Before this PR, running

cmsDriver.py TTbar_14TeV_TuneCP5_cfi  \
-s GEN,SIM -n 10 \
--conditions auto:phase2_realistic_T35 \
--beamspot DBrealisticHLLHC \
--datatier GEN-SIM \
--eventcontent FEVTDEBUG \
--geometry ExtendedRun4D110 \
--era Phase2C17I13M9 \
--relval 9000,100 \
--fileout file:step1.root

cmsDriver.py step2 \
-s DIGI:pdigi_valid,L1TrackTrigger,L1,L1P2GT,DIGI2RAW,HLT:@relvalRun4,NANO:@Phase2HLTVal \
-n 10 \
--conditions auto:phase2_realistic_T35 \
--datatier GEN-SIM-DIGI-RAW,NANOAODSIM \
--eventcontent FEVTDEBUGHLT,NANOAODSIM \
--geometry ExtendedRun4D110 \
--era Phase2C17I13M9 \
--customise SLHCUpgradeSimulations/Configuration/aging.customise_aging_1000 \
--filein  file:step1.root \
--fileout file:step2.root

would fail, while the workflow now runs and produces the expected "empty" valueMaps (filled with default values).

cmsbuild · 2026-04-15T14:55:30Z

cms-bot internal usage

cmsbuild · 2026-04-15T14:56:55Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-50730/49017

cmsbuild · 2026-04-15T14:57:16Z

A new Pull Request was created by @Parsifal-2045 for master.

It involves the following packages:

PhysicsTools/NanoAOD (xpog)

@battibass, @cmsbuild, @ftorrresd can you please review it and eventually sign? Thanks.
@gpetruc this is something you requested to watch as well.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

Parsifal-2045 · 2026-04-15T14:58:56Z

type ngt

ftorrresd · 2026-04-15T22:42:21Z

enable nano

ftorrresd · 2026-04-15T22:42:26Z

please test

cmsbuild · 2026-04-16T01:00:04Z

+1

Size: This PR adds an extra 24KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-04ed45/52696/summary.html
COMMIT: 5171c87
CMSSW: CMSSW_17_0_X_2026-04-15-2300/el8_amd64_gcc13
Additional Tests: NANO
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/50730/52696/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially removed 2 lines from the logs
Reco comparison results: 6 differences found in the comparisons
DQMHistoTests: Total files compared: 53
DQMHistoTests: Total histograms compared: 4186437
DQMHistoTests: Total failures: 3
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 4186414
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 52 files compared)
Checked 227 log files, 197 edm output root files, 53 DQM output files
TriggerResults: no differences found

Nano size comparison Summary:

workflow	id	kb/ev	ref kb/ev	diff kb/ev	ev/s/thd	ref ev/s/thd	diff rate	mem/thd	ref mem/thd
NANOmc106Xul16v2	2500.0001	3.094	3.094	0.000 ( +0.0% )	3.22	3.16	+1.7%	2.792	2.785
NANOmc106Xul16APVv2	2500.0002	3.048	3.048	0.000 ( +0.0% )	3.18	3.17	+0.3%	2.818	2.826
NANOmc106Xul17v2	2500.0003	3.153	3.153	0.000 ( +0.0% )	3.01	2.98	+1.0%	3.246	3.273
NANOmc106Xul18v2	2500.0004	3.105	3.105	0.000 ( +0.0% )	3.03	2.99	+1.2%	3.224	3.239
NANOdata106Xul16v2	2500.0101	1.540	1.540	0.000 ( +0.0% )	5.16	5.18	-0.5%	2.836	2.880
NANOdata106Xul17v2	2500.0102	1.926	1.926	0.000 ( +0.0% )	3.58	3.55	+0.8%	3.053	3.085
NANOdata106Xul18v2	2500.0103	1.890	1.890	0.000 ( +0.0% )	4.21	4.18	+0.7%	2.902	3.000
NANOmcUL16APVreMINI	2500.0201	0.022	0.022	0.000 ( +0.0% )	1.49	1.38	+7.8%	2.962	3.009
NANOmcUL16reMINI	2500.0202	0.022	0.022	0.000 ( +0.0% )	1.43	1.44	-0.8%	2.991	3.018
NANOmcUL17reMINI	2500.0203	0.022	0.022	0.000 ( +0.0% )	1.17	1.31	-10.8%	2.838	3.160
NANOmcUL18reMINI	2500.0204	0.022	0.022	0.000 ( +0.0% )	1.26	1.29	-2.3%	2.849	3.194
NANOdataUL16APVreMINI	2500.0301	0.035	0.035	0.000 ( +0.0% )	1.33	1.21	+10.6%	2.907	2.919
NANOdataUL16reMINI	2500.0302	0.036	0.036	0.000 ( +0.0% )	1.34	1.27	+4.9%	2.697	2.928
NANOdataUL17reMINI	2500.0303	0.037	0.037	0.000 ( +0.0% )	1.22	1.21	+1.0%	2.776	2.963
NANOdataUL18reMINI	2500.0304	0.036	0.036	0.000 ( +0.0% )	1.32	1.17	+12.7%	2.798	2.954
NANOmcUL16APVMini2Mini	2500.0401	0.023	0.023	0.000 ( +0.0% )	2.37	2.07	+14.5%	2.245	2.235
NANOmcUL16Mini2Mini	2500.0402	0.023	0.023	0.000 ( +0.0% )	2.17	1.92	+13.3%	2.217	2.271
NANOmcUL17Mini2Mini	2500.0403	0.023	0.023	0.000 ( +0.0% )	1.95	1.79	+8.8%	2.281	2.280
NANOmcUL18Mini2Mini	2500.0404	0.023	0.023	0.000 ( +0.0% )	1.97	1.91	+3.6%	2.294	2.284
NANOdataUL16Mini2Mini	2500.0501	0.039	0.039	0.000 ( +0.0% )	2.91	2.35	+24.1%	2.083	2.131
NANOdataUL17Mini2Mini	2500.0502	0.040	0.040	0.000 ( +0.0% )	2.22	1.91	+16.3%	2.142	2.199
NANOdataUL18Mini2Mini	2500.0503	0.039	0.039	0.000 ( +0.0% )	2.43	2.43	+0.1%	2.133	2.182
NANOmc130X	2500.1001	3.228	3.228	0.000 ( +0.0% )	3.59	3.57	+0.5%	3.156	3.235
NANOdata130Xrun3	2500.1101	1.790	1.790	0.000 ( +0.0% )	5.42	5.35	+1.1%	2.805	2.907
NANOmc23Mini2Mini	2500.1201	0.022	0.022	0.000 ( +0.0% )	2.26	2.09	+8.4%	2.157	2.162
NANOdata23Mini2Mini	2500.1301	0.041	0.041	0.000 ( +0.0% )	3.11	3.05	+2.0%	2.346	2.445
ScoutingNANOdata124Xrun3	2500.1501	0.772	0.772	0.000 ( +0.0% )	29.06	27.38	+6.1%	1.614	1.647
ScoutingNANOmonitordata124Xrun3	2500.1502	0.862	0.862	0.000 ( +0.0% )	11.55	10.74	+7.6%	1.447	1.485
ScoutingNANOdata130Xrun3	2500.1503	1.251	1.251	0.000 ( +0.0% )	20.99	19.33	+8.6%	1.463	1.620
ScoutingNANOmonitordata130Xrun3	2500.1504	1.297	1.297	0.000 ( +0.0% )	8.98	8.54	+5.1%	1.388	1.487
muPOGNANOmc140X	2500.2201	2.269	2.269	0.000 ( +0.0% )	4.70	4.43	+6.0%	2.287	2.283
EGMNANOmc140X	2500.2202	3.859	3.859	0.000 ( +0.0% )	3.13	3.36	-7.0%	2.462	2.684
BTVNANOmc140X	2500.2203	10.475	10.475	0.000 ( +0.0% )	2.15	1.97	+9.3%	2.611	2.902
jmeNANOmc140X	2500.2204	6.639	6.639	0.000 ( +0.0% )	0.95	0.93	+2.1%	2.743	2.752
lepTrackInfoNANOmc140X	2500.2206	3.553	3.553	0.000 ( +0.0% )	3.19	3.28	-2.6%	2.459	2.677
ScoutingNANOmc140X	2500.2207	1.488	1.488	0.000 ( +0.0% )	11.71	10.91	+7.3%	1.811	1.908
ScoutingNANOwithPromptmc140X	2500.2208	4.461	4.461	0.000 ( +0.0% )	2.80	2.81	-0.1%	2.730	3.079
muPOGNANO140Xrun3	2500.2301	1.683	1.683	0.000 ( +0.0% )	6.51	6.24	+4.4%	2.353	2.621
EGMNANOdata140Xrun3	2500.2302	2.623	2.623	0.000 ( +0.0% )	4.47	4.63	-3.4%	2.713	3.008
BTVNANOdata140Xrun3	2500.2303	5.612	5.612	0.000 ( +0.0% )	3.07	3.13	-2.0%	2.880	3.212
jmeNANOdata140Xrun3	2500.2304	3.976	3.976	0.000 ( +0.0% )	1.22	1.28	-4.7%	2.741	3.053
lepTrackInfoNANOdata140Xrun3	2500.2306	2.413	2.413	0.000 ( +0.0% )	4.79	5.03	-4.7%	2.729	3.004
ScoutingNANOdata140Xrun3	2500.2307	1.101	1.101	0.000 ( +0.0% )	25.87	26.45	-2.2%	1.472	1.636
ScoutingNANOmonitordata140Xrun3	2500.2308	2.784	2.784	0.000 ( +0.0% )	4.51	4.54	-0.5%	3.035	3.179
ScoutingNANOmonitorWithPromptdata140Xrun3	2500.2309	2.784	2.784	0.000 ( +0.0% )	4.56	4.57	-0.3%	2.999	3.174
L1ScoutingSelectionNANOdata140Xrun3	2500.2311	0.081	0.081	0.000 ( +0.0% )	44.94	40.96	+9.7%	0.842	0.849
L1ScoutingNANOdata140Xrun3	2500.231	0.082	0.082	0.000 ( +0.0% )	3.58	3.73	-4.0%	0.940	0.960
l1DPGNANO140Xrun3	2500.2401	9.405	9.405	0.000 ( +0.0% )	6.49	5.62	+15.5%	1.848	1.845
muDPGNANO140Xrun3	2500.2402	10.377	10.377	0.000 ( +0.0% )	1.53	1.57	-2.8%	1.698	1.696
muDPGNANOBkg140Xrun3	2500.2403	6.401	6.401	0.000 ( +0.0% )	14.04	13.45	+4.4%	1.243	1.266
hcalDPGNANO140Xrun3	2500.2404	486.015	486.015	0.000 ( +0.0% )	1.08	1.08	+0.6%	1.687	1.721
hcalDPGCalibNANO140Xrun3	2500.2405	826.418	826.418	0.000 ( +0.0% )	1.40	1.41	-0.9%	1.696	1.702
hcalDPGMCNANO140Xrun3	2500.2501	645.333	645.333	0.000 ( +0.0% )	1.50	1.54	-2.8%	1.704	1.804
NANOmc2024reMINI	2500.2601	0.021	0.021	0.000 ( +0.0% )	1.73	1.79	-3.7%	2.707	3.106
NANOdata2024reMINI	2500.2701	0.036	0.036	0.000 ( +0.0% )	1.66	1.78	-6.7%	2.663	2.882
NANOmc150X	2500.3001	3.224	3.224	0.000 ( +0.0% )	15.90	15.82	+0.5%	2.793	2.796
NANOdata150X	2500.3101	2.144	2.144	0.000 ( +0.0% )	30.89	32.24	-4.2%	2.503	2.542
NANOdata150X	2500.3102	2.630	2.630	0.000 ( +0.0% )	24.14	26.91	-10.3%	2.399	2.623
muPOGNANOmc150X	2500.3201	2.344	2.344	0.000 ( +0.0% )	14.75	14.16	+4.2%	2.583	2.652
EGMNANOmc150X	2500.3202	4.118	4.118	0.000 ( +0.0% )	13.18	12.58	+4.7%	2.783	2.779
BTVNANOmc150X	2500.3203	10.559	10.559	0.000 ( +0.0% )	4.34	4.15	+4.5%	2.817	3.014
jmeNANOmc150X	2500.3204	6.460	6.460	0.000 ( +0.0% )	1.18	1.21	-3.0%	2.747	2.968
jmeNANOrePuppimc150X	2500.3205	6.464	6.464	0.000 ( +0.0% )	1.16	1.09	+6.0%	3.235	3.235
lepTrackInfoNANOmc150X	2500.3206	3.728	3.728	0.000 ( +0.0% )	13.72	13.82	-0.7%	2.783	2.778
ScoutingNANOmc150X	2500.3207	1.563	1.563	0.000 ( +0.0% )	18.37	17.13	+7.2%	2.346	2.429
ScoutingNANOwithPromptmc150X	2500.3208	4.781	4.781	0.000 ( +0.0% )	10.07	9.36	+7.6%	2.956	2.950
BPHNANOmc150X	2500.3209	4.135	4.135	0.000 ( +0.0% )	16.20	13.86	+16.9%	2.793	2.852
muPOGNANO150Xrun3	2500.3301	1.244	1.244	0.000 ( +0.0% )	27.65	27.83	-0.6%	2.418	2.421
EGMNANOdata150Xrun3	2500.3302	2.985	2.985	0.000 ( +0.0% )	24.36	24.67	-1.2%	2.500	2.535
BTVNANOdata150Xrun3	2500.3303	7.971	7.971	0.000 ( +0.0% )	5.42	5.72	-5.3%	2.750	2.770
jmeNANOdata150Xrun3	2500.3304	4.349	4.349	0.000 ( +0.0% )	1.54	1.41	+9.1%	2.560	2.697
jmeNANOrePuppidata150Xrun3	2500.3305	4.332	4.332	0.000 ( +0.0% )	1.33	1.27	+5.1%	2.645	2.966
lepTrackInfoNANOdata150Xrun3	2500.3306	2.625	2.625	0.000 ( +0.0% )	26.38	26.36	+0.1%	2.528	2.527
ScoutingNANOdata150Xrun3	2500.3307	1.738	1.738	0.000 ( +0.0% )	29.75	26.86	+10.7%	1.644	1.645
ScoutingNANOmonitordata150Xrun3	2500.3308	1.400	1.400	0.000 ( +0.0% )	25.57	22.21	+15.1%	2.316	2.305
ScoutingNANOmonitorWithPromptdata150Xrun3	2500.3309	2.602	2.602	0.000 ( +0.0% )	17.28	15.21	+13.6%	2.599	2.719
L1ScoutingNANOdata150Xrun3	2500.3311	0.078	0.078	0.000 ( +0.0% )	3.49	2.87	+21.4%	0.960	0.952
L1ScoutingSelectionNANOdata150Xrun3	2500.3312	0.078	0.078	0.000 ( +0.0% )	25.45	19.09	+33.3%	0.962	0.969
BPHNANOdata150Xrun3	2500.331	2.632	2.632	0.000 ( +0.0% )	30.51	25.33	+20.5%	2.347	2.582
L1ScoutingNANOdata160Xrun3	2500.4301	0.110	0.110	0.000 ( +0.0% )	2.11	1.87	+13.2%	0.936	0.929
L1ScoutingSelectionNANOdata160Xrun3	2500.4302	0.113	0.113	0.000 ( +0.0% )	19.00	15.53	+22.4%	0.965	0.966
TTbarMINIAOD10.6_UL18v2	2500.9001	1.814	1.814	0.000 ( +0.0% )	34.25	26.10	+31.2%	1.914	1.916
TTbarMINIAOD14.0	2500.9002	1.662	1.662	0.000 ( +0.0% )	33.67	27.05	+24.5%	1.506	1.509
DYToLL_M-50_13TeV_pythia8	2500.9101	14.992	14.992	0.000 ( +0.0% )	7.15	4.52	+57.9%	1.161	1.158
DYToll01234Jets_5f_LO_MLM_Madgraph_LHE_13TeV	2500.9102	0.171	0.171	0.000 ( +0.0% )	2.87	1.57	+82.7%	0.894	0.894
TTbar_Pow_LHE_13TeV	2500.9103	0.110	0.110	0.000 ( +0.0% )	2.34	2.16	+8.4%	0.897	0.898

NANO Comparison Summary

Summary:

You potentially added 598 lines to the logs
ROOTFileChecks: Some differences in event products or their sizes found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 32
DQMHistoTests: Total histograms compared: 43020
DQMHistoTests: Total failures: 0
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 43020
DQMHistoTests: Total skipped: 0
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
Checked 189 log files, 110 edm output root files, 32 DQM output files
TriggerResults: no differences found

battibass · 2026-04-16T09:40:28Z

+1

cmsbuild · 2026-04-16T09:40:53Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @ftenchini, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

mmusich · 2026-04-17T13:58:56Z

just for the record, once #50748 gets merged, we should be able to test this module from the ph2_hlt matrix.

mandrenguyen · 2026-04-18T04:56:27Z

+1

Fix handling of empty inputs or invalid handles

5171c87

cmsbuild added this to the CMSSW_17_0_X milestone Apr 15, 2026

cmsbuild added pending-signatures tests-pending orp-pending code-checks-pending xpog-pending labels Apr 15, 2026

cmsbuild added code-checks-approved and removed code-checks-pending labels Apr 15, 2026

cmsbuild added the ngt label Apr 15, 2026

cmsbuild added tests-started and removed tests-pending labels Apr 15, 2026

cmsbuild added tests-approved and removed tests-started labels Apr 16, 2026

cmsbuild added fully-signed xpog-approved and removed pending-signatures xpog-pending labels Apr 16, 2026

cmsbuild removed the orp-pending label Apr 18, 2026

cmsbuild added the orp-approved label Apr 18, 2026

cmsbuild merged commit 8c041ce into cms-sw:master Apr 18, 2026
12 checks passed

This was referenced Apr 18, 2026

Add CXXFLAGS for unused result warning cms-sw/cmsdist#10492

Merged

[EVO] Fix merge conflicts 2026/04/20 #50767

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Improve handling of missing/invalid inputs in `TrackingAssocValueMapsProducer`#50730

Improve handling of missing/invalid inputs in `TrackingAssocValueMapsProducer`#50730
cmsbuild merged 1 commit into
cms-sw:masterfrom
Parsifal-2045:fixTrackingAssocValueMapProducer

Parsifal-2045 commented Apr 15, 2026 •

edited

Loading

Uh oh!

cmsbuild commented Apr 15, 2026 •

edited

Loading

Uh oh!

cmsbuild commented Apr 15, 2026

Uh oh!

cmsbuild commented Apr 15, 2026

Uh oh!

Parsifal-2045 commented Apr 15, 2026

Uh oh!

ftorrresd commented Apr 15, 2026

Uh oh!

ftorrresd commented Apr 15, 2026

Uh oh!

cmsbuild commented Apr 16, 2026

Uh oh!

battibass commented Apr 16, 2026

Uh oh!

cmsbuild commented Apr 16, 2026

Uh oh!

mmusich commented Apr 17, 2026

Uh oh!

mandrenguyen commented Apr 18, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Conversation

Parsifal-2045 commented Apr 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR description:

PR validation:

Uh oh!

cmsbuild commented Apr 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cmsbuild commented Apr 15, 2026

Uh oh!

cmsbuild commented Apr 15, 2026

Uh oh!

Parsifal-2045 commented Apr 15, 2026

Uh oh!

ftorrresd commented Apr 15, 2026

Uh oh!

ftorrresd commented Apr 15, 2026

Uh oh!

cmsbuild commented Apr 16, 2026

Comparison Summary

NANO Comparison Summary

Uh oh!

battibass commented Apr 16, 2026

Uh oh!

cmsbuild commented Apr 16, 2026

Uh oh!

mmusich commented Apr 17, 2026

Uh oh!

mandrenguyen commented Apr 18, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Parsifal-2045 commented Apr 15, 2026 •

edited

Loading

cmsbuild commented Apr 15, 2026 •

edited

Loading