Skip to content

Add class versions to MtdSim{LayerCluster,Trackster}#50418

Merged
cmsbuild merged 1 commit into
cms-sw:masterfrom
makortel:evolutionMtdClassVersion
Mar 19, 2026
Merged

Add class versions to MtdSim{LayerCluster,Trackster}#50418
cmsbuild merged 1 commit into
cms-sw:masterfrom
makortel:evolutionMtdClassVersion

Conversation

@makortel
Copy link
Copy Markdown
Contributor

@makortel makortel commented Mar 16, 2026

PR description:

I noticed in #50416 (comment) these two classes should have class versions in their dictionaries.

Resolves cms-sw/framework-team#2041

PR validation:

Code compiles

@cmsbuild
Copy link
Copy Markdown
Contributor

cmsbuild commented Mar 16, 2026

cms-bot internal usage

@cmsbuild
Copy link
Copy Markdown
Contributor

@cmsbuild
Copy link
Copy Markdown
Contributor

A new Pull Request was created by @makortel for master.

It involves the following packages:

  • SimDataFormats/CaloAnalysis (simulation)

@civanch, @cmsbuild, @kpedro88, @mdhildreth can you please review it and eventually sign? Thanks.
@ReyerBand, @apsallid, @bsunanda, @denizsun, @fabiocos, @felicepantaleo, @martinamalberti, @missirol, @mmusich, @rovere, @salimcerci, @thomreis, @wang0jin this is something you requested to watch as well.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@makortel
Copy link
Copy Markdown
Contributor Author

@cmsbuild, please test

@cmsbuild
Copy link
Copy Markdown
Contributor

+1

Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-610d6d/52063/summary.html
COMMIT: f564e21
CMSSW: CMSSW_16_1_X_2026-03-17-2300/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/50418/52063/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 2 lines to the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 53
  • DQMHistoTests: Total histograms compared: 4185208
  • DQMHistoTests: Total failures: 45
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 4185143
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 52 files compared)
  • Checked 227 log files, 198 edm output root files, 53 DQM output files
  • TriggerResults: no differences found

@makortel
Copy link
Copy Markdown
Contributor Author

@cms-sw/simulation-l2 Could review and sign, please? Thanks!

@civanch
Copy link
Copy Markdown
Contributor

civanch commented Mar 19, 2026

+1

@cmsbuild
Copy link
Copy Markdown
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @ftenchini, @sextonkennedy, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

@ftenchini
Copy link
Copy Markdown

+1

@cmsbuild cmsbuild merged commit d95f0a0 into cms-sw:master Mar 19, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add class versions to MtdSim{LayerCluster,Trackster}

4 participants