[EVO] Moved GlobalObjectMapRecord back to global namespace by Dr15Jones · Pull Request #50483 · cms-sw/cmssw

Dr15Jones · 2026-03-20T14:04:11Z

PR description:

This type is stored in the RAW data format so must remain in the global namespace to allow reading old files.

PR validation:

Code compiles.

resolves cms-sw/framework-team#2064

cmsbuild · 2026-03-20T14:04:36Z

cms-bot internal usage

Dr15Jones · 2026-03-20T14:05:50Z

type evo

Dr15Jones · 2026-03-20T14:06:01Z

assign core

Dr15Jones · 2026-03-20T14:06:05Z

please test

cmsbuild · 2026-03-20T14:06:21Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-50483/48634

cmsbuild · 2026-03-20T14:06:44Z

New categories assigned: core

@Dr15Jones,@makortel,@smuzaffar you have been requested to review this Pull request/Issue and eventually sign? Thanks

cmsbuild · 2026-03-20T14:06:47Z

A new Pull Request was created by @Dr15Jones for CMSSW_16_1_EVOLUTION_X.

It involves the following packages:

DataFormats/L1TGlobal (l1)

@BenjaminRS, @Dr15Jones, @makortel, @quinnanm, @smuzaffar can you please review it and eventually sign? Thanks.
@missirol, @mmusich, @rovere this is something you requested to watch as well.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

cmsbuild · 2026-03-20T16:10:32Z

-1

Failed Tests: Build
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4aa210/52116/summary.html
COMMIT: 7773e86
CMSSW: CMSSW_16_1_EVOLUTION_X_2026-03-16-2300/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/50483/52116/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4aa210/52116/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4aa210/52116/git-merge-result

Failed Build

I found compilation error when building:

>> Checking EDM Class Version for src/SimDataFormats/TrackingHit/src/classes_def.xml in SimDataFormatsTrackingHit
@@@@ ----> OK EDM Class Version RecoTrackerTkSeedingLayers
>> Checking EDM Class Transients in RecoTrackerTkSeedingLayers
@@@@ ----> OK EDM Class Version RecoTrackerTkTrackingRegions
>> Checking EDM Class Transients in RecoTrackerTkTrackingRegions
error: class 'MtdSimLayerCluster' has a different checksum for ClassVersion 3. Increment ClassVersion to 4 and assign it to checksum 2390344788
error: class 'MtdSimTrackster' has a different checksum for ClassVersion 3. Increment ClassVersion to 4 and assign it to checksum 2148606150
Suggestion: You can run 'scram build updateclassversion' to generate src/SimDataFormats/CaloAnalysis/src/classes_def.xml.generated with updated ClassVersion
gmake: *** [tmp/el8_amd64_gcc13/edm_checks/libSimDataFormatsCaloAnalysis.so] Error 1
>> Checking EDM Class Version for src/SimDataFormats/Vertex/src/classes_def.xml in SimDataFormatsVertex
@@@@ ----> OK EDM Class Transients RecoTrackerPixelSeeding

Dr15Jones · 2026-03-20T16:19:00Z

It seems like the class version problem is already in the CMSSW_16_1_EVOLUTION_X branch. As far as I can tell, no *DataFormats object depends on GlobalObjectMapRecord.

makortel · 2026-03-20T17:09:21Z

That looks like a knock-on effect of #50418 and the classes have different checksums in EVOLUTION_X. I'll submit a fix.

Dr15Jones · 2026-03-22T12:46:51Z

Please test with #50485

cmsbuild · 2026-03-22T13:32:35Z

-1

Failed Tests: UnitTests RelVals AddOn
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4aa210/52129/summary.html
COMMIT: 7773e86
CMSSW: CMSSW_16_1_EVOLUTION_X_2026-03-20-2300/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/50483/52129/install.sh to create a dev area with all the needed externals and cmssw changes.

Failed Unit Tests

I found 3 errors in the following unit tests:

---> test test_MC_23_crosscheck had ERRORS
---> test test_MC_22_crosscheck had ERRORS
---> test TestGlobalObjectMapRecordFormat had ERRORS

Failed RelVals

135.4135.4_ZEEFS_13/step1_ZEEFS_13.log
2025.00000012025.0000001_RunZeroBias2025B_10k/step2_RunZeroBias2025B_10k.log
34434.7534434.75_TTbar_14TeV+Run4D121_HLT75e33Timing/step1_TTbar_14TeV+Run4D121_HLT75e33Timing.log

Expand to see more relval errors ...

Failed AddOn Tests

fastsim

UNKNOWN

fastsim1

UNKNOWN

fastsim2

UNKNOWN

Expand to see more addon errors ...

This type is stored in the RAW data format so must remain in the global namespace to allow reading old files.

Dr15Jones · 2026-03-22T14:05:40Z

Please test with #50485

cmsbuild · 2026-03-22T14:06:56Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-50483/48647

cmsbuild · 2026-03-22T14:07:24Z

Pull request #50483 was updated. @BenjaminRS, @Dr15Jones, @makortel, @quinnanm, @smuzaffar can you please check and sign again.

cmsbuild · 2026-03-22T14:30:37Z

-1

Failed Tests: UnitTests RelVals AddOn
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4aa210/52131/summary.html
COMMIT: 42f8fc2
CMSSW: CMSSW_16_1_EVOLUTION_X_2026-03-20-2300/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/50483/52131/install.sh to create a dev area with all the needed externals and cmssw changes.

Failed Unit Tests

I found 2 errors in the following unit tests:

---> test test_MC_23_crosscheck had ERRORS
---> test test_MC_22_crosscheck had ERRORS

Failed RelVals

135.4135.4_ZEEFS_13/step1_ZEEFS_13.log
2025.00000012025.0000001_RunZeroBias2025B_10k/step2_RunZeroBias2025B_10k.log
9.09.0_Higgs200ChargedTaus/step1_Higgs200ChargedTaus.log

Expand to see more relval errors ...

Failed AddOn Tests

fastsim

UNKNOWN

fastsim1

UNKNOWN

fastsim2

UNKNOWN

Expand to see more addon errors ...

makortel · 2026-03-23T13:47:13Z

ignore tests-rejected with manual-override

The EVOLUTION_X IB is broken at the moment, but I think we can proceed with this PR (based on it compiling).

makortel · 2026-03-23T13:47:36Z

+core

By eye verified the partial revert of #50438

mandrenguyen · 2026-03-24T16:23:09Z

merge

cmsbuild added l1-pending pending-signatures tests-pending orp-pending code-checks-pending changes-dataformats labels Mar 20, 2026

cmsbuild added core-pending tests-started evolution and removed tests-pending labels Mar 20, 2026

cmsbuild added code-checks-approved and removed code-checks-pending labels Mar 20, 2026

cmsbuild added tests-rejected and removed tests-started labels Mar 20, 2026

makortel mentioned this pull request Mar 20, 2026

[EVOLUTION_X] Update checksums for MtdSim{LayerCluster,Trackster} #50485

Merged

cmsbuild added requires-external tests-started and removed tests-rejected labels Mar 22, 2026

Moved GlobalObjectMapRecord back to global namespace

42f8fc2

This type is stored in the RAW data format so must remain in the global namespace to allow reading old files.

Dr15Jones force-pushed the evo_revertGlobalObjectMapRecord branch from 7773e86 to 42f8fc2 Compare March 22, 2026 14:05

cmsbuild added tests-pending code-checks-pending and removed tests-rejected requires-external code-checks-approved labels Mar 22, 2026

cmsbuild added tests-started requires-external and removed tests-pending labels Mar 22, 2026

cmsbuild added code-checks-approved and removed code-checks-pending labels Mar 22, 2026

cmsbuild added tests-rejected and removed tests-started labels Mar 22, 2026

cmsbuild added tests-approved tests-manual-override and removed tests-rejected labels Mar 23, 2026

cmsbuild added core-approved and removed core-pending labels Mar 23, 2026

cmsbuild added orp-approved and removed orp-pending labels Mar 24, 2026

cmsbuild merged commit da0bd1e into cms-sw:CMSSW_16_1_EVOLUTION_X Mar 24, 2026
6 of 9 checks passed

Dr15Jones deleted the evo_revertGlobalObjectMapRecord branch April 7, 2026 13:26

Conversation

Dr15Jones commented Mar 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR description:

PR validation:

Uh oh!

cmsbuild commented Mar 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Dr15Jones commented Mar 20, 2026

Uh oh!

Dr15Jones commented Mar 20, 2026

Uh oh!

Dr15Jones commented Mar 20, 2026

Uh oh!

cmsbuild commented Mar 20, 2026

Uh oh!

cmsbuild commented Mar 20, 2026

Uh oh!

cmsbuild commented Mar 20, 2026

Uh oh!

cmsbuild commented Mar 20, 2026

Failed Build

Uh oh!

Dr15Jones commented Mar 20, 2026

Uh oh!

makortel commented Mar 20, 2026

Uh oh!

Dr15Jones commented Mar 22, 2026

Uh oh!

cmsbuild commented Mar 22, 2026

Failed Unit Tests

Failed RelVals

Failed AddOn Tests

Uh oh!

Dr15Jones commented Mar 22, 2026

Uh oh!

cmsbuild commented Mar 22, 2026

Uh oh!

cmsbuild commented Mar 22, 2026

Uh oh!

cmsbuild commented Mar 22, 2026

Failed Unit Tests

Failed RelVals

Failed AddOn Tests

Uh oh!

makortel commented Mar 23, 2026

Uh oh!

makortel commented Mar 23, 2026

Uh oh!

mandrenguyen commented Mar 24, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Dr15Jones commented Mar 20, 2026 •

edited

Loading

cmsbuild commented Mar 20, 2026 •

edited

Loading