Particle Flow cluster validation in ECAL#50292
Conversation
|
type ngt |
|
cms-bot internal usage |
|
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-50292/48335
Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
cmsbuild
added
code-checks-rejected
code-checks-pending
and removed
code-checks-pending
code-checks-rejected
labels
|
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-50292/48336
Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
cmsbuild
added
code-checks-pending
and removed
operations-pending
code-checks-rejected
labels
|
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-50292/48341
Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
bfonta
force-pushed
the
ParticleFlowECALClusterValidation
branch
from
fb992c8 to
2fb9d85
Compare
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-50292/49192
|
|
Pull request #50292 was updated. @Moanwar, @civanch, @cmsbuild, @ctarricone, @gabrielmscampos, @jfernan2, @kpedro88, @mandrenguyen, @mdhildreth, @nothingface0, @rseidita, @srimanob can you please check and sign again. |
|
-1 Failed Tests: RelVals-INPUT Failed RelVals-INPUT
Comparison SummarySummary:
Max Memory Comparisons exceeding threshold@cms-sw/core-l2 , I found 26 workflow step(s) with memory usage exceeding the error threshold: Expand to see workflows ...
|
|
test parameters:
To work around #50844 |
|
@cmsbuild, please test |
|
-1 Failed Tests: RelVals-INPUT Failed RelVals-INPUT
Comparison SummarySummary:
Max Memory Comparisons exceeding threshold@cms-sw/core-l2 , I found 26 workflow step(s) with memory usage exceeding the error threshold: Expand to see workflows ...
|
|
test parameters:
|
|
@cmsbuild, please test (sigh) |
|
-1 Failed Tests: RelVals The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: You can see more details here: Failed RelVals
Expand to see more relval errors ...
|
|
Ok... The failures are now These seem to be related to cms-sw/cms-bot#2733 |
|
test parameters:
|
|
@cmsbuild, please test |
|
+1 Size: This PR adds an extra 16KB to repository Comparison SummaryThere are some workflows for which there are errors in the baseline: Summary:
|
|
please test |
|
-1 Failed Tests: RelVals-INPUT The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: You can see more details here: Failed RelVals-INPUT
Expand to see more relval errors ...
Comparison SummarySummary:
Max Memory Comparisons exceeding threshold@cms-sw/core-l2 , I found 40 workflow step(s) with memory usage exceeding the error threshold: Expand to see workflows ...
|
|
The ModuleAllocMonitor diff reports continue to point to I think it is not worth of holding this PR further just because of the header parsing (I haven't paid attention if the review has otherwise concluded) |
|
With help of @yashmehra028 we've tested this PR on the new As a sidenote, we had to manually |
Can you share the results of such validation in this thread?
If this product needs to be consumed in a "step3-like" job and is produced in the earlier step-2 HLT job, then yes it needs to be persisted in the event content of the |
|
@cmsbuild, please test
|
|
+1 Size: This PR adds an extra 16KB to repository Comparison SummarySummary:
Max Memory Comparisons exceeding threshold@cms-sw/core-l2 , I found 12 workflow step(s) with memory usage exceeding the error threshold: Expand to see workflows ...
|
|
Thanks @bfonta , So I think this would need some modifications based on cms-ngt-hlt#6 |
and addressing #50292 (comment) |
11 participants
PR description:
This work introduces PF cluster validation at HLT in ECAL. It marks the first of a series of efforts to develop a central tool for PF validation @ HLT.
Content
Connection to previous PRs
Instructions
runTheMatrix.py -l 36136.0 -w upgrade -j0and replace the defaultDoubleElectronFlatPt1p5To8_cfibySingleElectronFlatPt2To100_cfi:cmsDriver.py SingleElectronFlatPt2To100_cfi -s GEN,SIM -n 10 --conditions auto:phase2_realistic_T35 --beamspot DBrealisticHLLHC --datatier GEN-SIM --eventcontent FEVTDEBUG --geometry ExtendedRun4D125 --era Phase2C22I13M9 --relval 9000,100 --fileout file:step1.root cmsDriver.py step2 -s DIGI:pdigi_valid,L1TrackTrigger,L1,L1P2GT,DIGI2RAW,HLT:@relvalRun4 --conditions auto:phase2_realistic_T35 --datatier GEN-SIM-DIGI-RAW -n 10 --eventcontent FEVTD\ EBUGHLT --geometry ExtendedRun4D125 --era Phase2C22I13M9 --filein file:step1.root --fileout file:step2.root cmsDriver.py step3 -s RAW2DIGI,RECO,RECOSIM,PAT,VALIDATION:@phase2Validation+@miniAODValidation,DQM:@phase2+@miniAODDQM --conditions auto:phase2_realistic_T35 --datatier GEN-SIM-RECO\ ,MINIAODSIM,DQMIO -n 10 --eventcontent FEVTDEBUGHLT,MINIAODSIM,DQM --geometry ExtendedRun4D125 --era Phase2C22I13M9 --filein file:step2.root --fileout file:step3.root cmsDriver.py step4 -s HARVESTING:@phase2Validation+@phase2+@miniAODValidation+@miniAODDQM --conditions auto:phase2_realistic_T35 --mc --geometry ExtendedRun4D125 --scenario pp --fil\ etype DQM --era Phase2C22I13M9 -n 10 --filein file:step3_inDQM.root --fileout file:step4.root cmsDriver.py step5 -s ALCA:SiPixelCalSingleMuonLoose+SiPixelCalSingleMuonTight+TkAlMuonIsolated+TkAlMinBias+MuAlOverlaps+EcalESAlign+TkAlZMuMu+TkAlDiMuonAndVertex+HcalCalHBHEMuonProd\ ucerFilter+TkAlUpsilonMuMu+TkAlJpsiMuMu --conditions auto:phase2_realistic_T35 --datatier ALCARECO -n 10 --eventcontent ALCARECO --geometry ExtendedRun4D125 --era Phase2C22I13M9 --fil\ ein file:step3.root --fileout file:step5.root python3 ${CMSSW_BASE}/src/Validation/RecoParticleFlow/scripts/makeHLTPFValidationPlots.py --file DQM_V0001_R000000001__Global__CMSSW_X_Y_Z__RECO.root --odir ./Plots -l 'SingleEle NoPU' --era Phase2dqm-plotPresentations
PR validation:
Tested with Single and CloseBy electron guns, in Run-3 and Phase-2 conditions.
Co-authored by @elenavernazza.