Conversation
…urn childrenAdded from controller continue()
Co-authored-by: Oliver Foster <oliver.foster@kineo.com>
Contributor
Author
|
Ready for re-review. Note dependency on Core 870. Also would like to work on #259 once this PR is approved. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #232
Update
_globals._extensions._trickle.additionalContentLoadedin course.json.Fix
Dependencies
Depends on the focus-restoration fix in core: adapt-contrib-core#870 (fixes #869). Without it, screen reader focus may briefly land in the navbar after the announcement closes when the clicked Trickle button is hidden via
_styleAfterClick: "hidden"(the default). The announcement itself plays correctly either way; only the focus landing point is affected.Testing
Set
_globals._extensions._trickle.additionalContentLoadedto a short message like"Loading."in course.json. Configure Trickle on several blocks covering the variations below.For each variation, use a screen reader (VoiceOver on macOS recommended; NVDA / JAWS on Windows for cross-SR coverage). Activate Trickle to unlock the next block.
Expected on each variation:
Variations
wait.queue()onpopup:closingdefers Trickle so the announce fires after the feedback popup closes, not during.Negative checks
_globals._extensions._trickle.additionalContentLoaded(or set it to an empty string). Confirm no announcement plays and Trickle still functions normally.