Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #869
Fix
notifyPushView.closePush()now only callsa11y.gotoPreviousActiveElement()when focus was actually inside the push element at close time. Push notifications never grab focus on open (non-modal<dialog>,aria-modal=\"false\"), so an auto-close where the user never tabbed in has no focus contract to restore. The unconditional restore was sending focus toAdapt.navigation(navbar) when the previous active element was no longer readable (e.g. a clicked button that was hidden after click) - see #869 for the full repro viaadapt-contrib-tricklePR #233.Testing
adapt-contrib-trickleconfigured with_styleAfterClick: \"hidden\"(default) on a block, the issue/232 branch of trickle, and anadditionalContentLoadedglobals message sonotify.readis called.gotoPreviousActiveElement._openNotifyOnClick) - separate popup handles its own focus contract.Posted via collaboration with Claude Code