-
Notifications
You must be signed in to change notification settings - Fork 32
Update: Alert screen reader users when content has been added (fixes #232) #233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
swashbuck
wants to merge
17
commits into
master
Choose a base branch
from
issue/232
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 8 commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
ce2ae91
Add additionalContentLoaded property to schemas
swashbuck fa2584f
Fix linting warnings
swashbuck c3e1053
Add announceContentLoaded()
swashbuck 7af880b
Add status element to template, move message code to button view, ret…
swashbuck 074dc10
Prevent hiding the trickle status element
swashbuck 7740c4f
Delay message so that screen readers catch it
swashbuck f4daef6
Shorten message, switch to notify push, add delay before focusing
swashbuck 734159f
Further shorten additionalContentLoaded default value
swashbuck e6a63e0
Revert aria-label selector
swashbuck 95e714f
Wrap announceContentLoaded in inverted if
swashbuck 64c09c3
Add comment in announceContentLoaded
swashbuck 67fa3da
Update js/TrickleButtonView.js
swashbuck f1cbb88
Merge branch 'master' into issue/232
swashbuck 7e655cd
Updated trickle to nominate the next added descendant on popup close
oliverfoster 0c1cfff
Merge branch 'master' into issue/232
swashbuck 672c3b1
Update: fire announceContentLoaded concurrent with load so SR reads d…
swashbuck 819fcf4
Add migration script
swashbuck File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.