Skip to content

Fix OOB write for halo threads in find_tracks #1357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
stephenswat wants to merge 1 commit into
base: main
Choose a base branch
from
+5 −2
Open

Fix OOB write for halo threads in find_tracks #1357

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,6 +162,7 @@ if( TRACCC_SETUP_VECMEM )
endif()

# Set up TBB.
message(STATUS "START TBBBBB")
option( TRACCC_SETUP_TBB
"Set up the TBB target(s) explicitly" TRUE )
if (TRACCC_USE_SYSTEM_LIBS OR TRACCC_USE_SPACK_LIBS)
Expand All @@ -175,11 +176,13 @@ option( TRACCC_USE_SYSTEM_TBB
unset(TRACCC_USE_SYSTEM_TBB_DEFAULT)
if( TRACCC_SETUP_TBB )
if( TRACCC_USE_SYSTEM_TBB )
message(STATUS "BUTTOCKS")
find_package( TBB REQUIRED )
else()
add_subdirectory( extern/tbb )
endif()
endif()
message(STATUS "END TBBBBB")

# Set up CCCL.
option( TRACCC_SETUP_THRUST
Expand Down Expand Up @@ -297,7 +300,7 @@ endif()

# Set up Acts.
option( TRACCC_SETUP_ACTS
"Set up the Acts target(s) explicitly" TRUE )
"Set up the Acts tmrget(s) explicitly" TRUE )
if (TRACCC_USE_SYSTEM_LIBS OR TRACCC_USE_SPACK_LIBS)
set(TRACCC_USE_SYSTEM_ACTS_DEFAULT ON)
else()
Expand Down
2 changes: 1 addition & 1 deletion device/common/include/traccc/finding/device/impl/find_tracks.ipp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -653,7 +653,7 @@ TRACCC_HOST_DEVICE inline void find_tracks(
tip_lengths.at(tip_pos) = n_cands;
}
}
} else {
} else if (in_param_id < payload.n_in_params) {
out_params_per_in_param.at(in_param_id) = 0;
}

Expand Down
Loading