Fix OOB write for halo threads in find_tracks#1357
Open
stephenswat wants to merge 1 commit into
Open
Conversation
This commit fixes a bug in the `find_tracks` kernel where halo threads would attempt to write outside the bounds of the parameter counting vector. This is easily fixed by wrapping the else clause in an additional check to establish whether the thread is actually part of the functional grid.
stephenswat
requested review from
krasznaa and
niermann999
and removed request for
niermann999
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit fixes a bug in the
find_trackskernel where halo threads would attempt to write outside the bounds of the parameter counting vector. This is easily fixed by wrapping the else clause in an additional check to establish whether the thread is actually part of the functional grid.