Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion lib/winston/logger.js
Original file line number Diff line number Diff line change
Expand Up @@ -48,11 +48,12 @@ class Logger extends Transform {
write: {
value: function (info) {
const infoClone = Object.assign(
{},
Object.create(Object.getPrototypeOf(info)),
defaultRequestMetadata,
info
);

// Object.create preserves the prototype chain but
// Object.assign doesn't copy inherited Error
// properties so we have to do that explicitly
//
Expand Down
25 changes: 25 additions & 0 deletions test/unit/winston/logger.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -988,6 +988,31 @@ describe('Logger Instance', function () {
childLogger.error(Error('dummy error', { cause: Error('dummy error cause') }));
});

it('preserves prototype of info object in child logger', (done) => {
class CustomError extends Error {
constructor(message) {
super(message);
this.custom = true;
}
}

const assertFn = ((msg) => {
assume(msg.level).equals('error');
assume(msg.custom).is.true();
assume(msg.requestId).equals('123');
done();
});

const logger = winston.createLogger({
transports: [
mockTransport.createMockTransport(assertFn)
]
});

const childLogger = logger.child({ requestId: '123' });
childLogger.error(new CustomError('custom error'));
});

it('defaultMeta() autobinds correctly', (done) => {
const logger = helpers.createLogger(info => {
assume(info.message).equals('test');
Expand Down