fix: preserve prototype chain in child logger info objects#2609
Open
mixelburg wants to merge 1 commit into
Open
fix: preserve prototype chain in child logger info objects#2609mixelburg wants to merge 1 commit into
mixelburg wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2577
The
child()method usesObject.assign({}, defaultRequestMetadata, info)to merge metadata, which only copies enumerable own properties. Wheninfois an Error subclass or any custom class instance, its prototype chain is lost —instanceofchecks and custom methods no longer work.The existing code already handles Error explicitly by copying
stack,message, andcause, but this doesn't cover custom subclasses or non-Error prototypes. UsingObject.create(Object.getPrototypeOf(info))as the target forObject.assignpreserves the prototype chain for all objects, not just Error instances.