Fix ask-question option row vertical alignment#11717
Conversation
Co-Authored-By: Oz <oz-agent@warp.dev>
|
I'm starting a first review of this pull request. You can view the conversation on Warp. I completed the review and no human review was requested for this pull request. Comment Powered by Oz |
![oz-for-oss[bot]](https://avatars.githubusercontent.com/in/3450139?s=60&v=4){kind=small}
There was a problem hiding this comment.
Overview
This PR changes the shared numbered shortcut button row to center-align the numbered badge with the option content, addressing the ask-question option row vertical alignment issue. The provided before/after screenshots satisfy the visual-evidence requirement for this user-facing UI change.
Concerns
- No blocking correctness, spec, or security concerns found in the changed lines.
Verdict
Found: 0 critical, 0 important, 0 suggestions
Approve
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
Co-Authored-By: Oz <oz-agent@warp.dev>
|
/oz-review |
|
I'm re-reviewing this pull request in response to a review request. You can view the conversation on Warp. I completed the review and no human review was requested for this pull request. Comment Powered by Oz |
There was a problem hiding this comment.
Overview
This PR adjusts the ask-question numbered option row spacing so the shortcut badge aligns with the option text. The change is limited to local layout math in the shared numbered button component, and the PR description includes before/after screenshots for the user-facing behavior.
Concerns
- No blocking correctness, security, or spec-alignment concerns found.
Verdict
Found: 0 critical, 0 important, 0 suggestions
Approve
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
szgupta
left a comment
szgupta
left a comment
There was a problem hiding this comment.
nice eye, question about impl tho
| / 2.; | ||
|
|
||
| let row = Flex::row() | ||
| .with_cross_axis_alignment(CrossAxisAlignment::Start) |
There was a problem hiding this comment.
I'm confused by this diff - shouldn't this be changed?
2 participants
Description
Fix vertical alignment of the numbered badge relative to the answer text in ask-question tool option rows.
The shared numbered shortcut button row was using top/start cross-axis alignment, which made the badge sit off-center next to single-line answer text. This switches the row to center cross-axis alignment so the badge and label content line up vertically.
Before
After
Linked Issue
ready-to-specorready-to-implement.Slack thread: feedback-app
1779388093.780329Testing
cargo check --manifest-path /workspace/warp/Cargo.toml -p warp --libcargo fmt --allcargo clippy --workspace --all-targets --all-features --tests -- -D warningscargo test -p warp number_shortcut_buttons --lib./script/runScreenshots / Videos
Computer-use visual verification was attempted twice, but the ask-question UI could not be reached in the sandboxed environment: the first attempt reached the agent request and was blocked by a staging 403 for AI features; the retry was blocked by the local app onboarding/browser-based sign-in flow before the ask-question tool could run.
Agent Mode
CHANGELOG-NONE
Conversation: https://staging.warp.dev/conversation/c8254208-0a95-4aeb-9ce9-78ba26c48fe5
Co-Authored-By: Oz oz-agent@warp.dev