Fix: Ask question tool option row vertical alignment#11715
Conversation
|
I'm starting a first review of this pull request. You can view the conversation on Warp. I completed the review and no human review was requested for this pull request. Comment Powered by Oz |
![oz-for-oss[bot]](https://avatars.githubusercontent.com/in/3450139?s=60&v=4){kind=small}
There was a problem hiding this comment.
Overview
This PR changes the ask-question option row layout so the numbered badge is vertically centered with the answer text.
Concerns
- This is a user-facing UI alignment change, but the PR description only states it was visually verified and does not attach a screenshot or screen recording. Please include visual evidence demonstrating the option row alignment end to end.
Verdict
Found: 0 critical, 1 important, 0 suggestions
Request changes
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
|
|
||
| let row = Flex::row() | ||
| .with_cross_axis_alignment(CrossAxisAlignment::Start) | ||
| .with_cross_axis_alignment(CrossAxisAlignment::Center) |
There was a problem hiding this comment.
There was a problem hiding this comment.
Overview
This PR changes the ask-question option row layout so the numbered badge is vertically centered with the answer text.
Concerns
- This is a user-facing UI alignment change, but the PR description only states it was visually verified and does not attach a screenshot or screen recording. Please include visual evidence demonstrating the option row alignment end to end.
Verdict
Found: 0 critical, 1 important, 0 suggestions
Request changes
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
|
|
||
| let row = Flex::row() | ||
| .with_cross_axis_alignment(CrossAxisAlignment::Start) | ||
| .with_cross_axis_alignment(CrossAxisAlignment::Center) |
There was a problem hiding this comment.
|
Superseded by #11717 on the requested oz-agent-prefixed branch with corrected metadata and validation notes. |
1 participant
Description
Fix vertical alignment of the numbered badge relative to the answer text in ask-question tool option rows.
The number badge and answer text in each option row were misaligned — the badge started lower than the text (y-axis). This was caused by the row using
CrossAxisAlignment::Startinstead ofCrossAxisAlignment::Center, so the badge was top-aligned rather than vertically centered with the answer text.Change: In
numbered_button.rs, switched the row's cross-axis alignment fromStarttoCenterso the numbered badge is vertically centered with the option text.Linked Issue
ready-to-specorready-to-implement.Testing
./script/runScreenshots / Videos
Verified visually via
./script/run— the numbered badge now vertically centers with the answer text in each option row.Agent Mode
CHANGELOG-BUG-FIX: Fixed vertical alignment of numbered badges in ask-question tool option rows