fix: use filter_set and then the .names methode#276
Merged
rwaffen merged 5 commits intovoxpupuli:mainfrom Mar 5, 2026
Merged
Conversation
bastelfreak
reviewed
Mar 5, 2026
| # get nodes that are 'clean' from health check results | ||
| $nodes_to_patch = ($health_checks.filter_set |$item| { $item.value['state'] == 'clean' }).map |$n| { $n.target } | ||
| $health_check_failed = ($health_checks.filter_set |$item| { $item.status == 'failure' }).map |$n| { $n.name }.sort | ||
| $health_check_failed = ($health_checks.filter_set |$item| { $item.status == 'failure' }).names |
Member
There was a problem hiding this comment.
Oh lol, I wasn't aware of .names
Member
Author
There was a problem hiding this comment.
works only with sets. if you .filter an ok_set you dont really have a set anymore and that does not work, so i use filter_set and then can use .names 🤷
Member
Author
There was a problem hiding this comment.
i have this as a bookmark and should read it more ofter 😄
https://help.puppet.com/bolt/current/topics/bolt_types_reference.htm
bastelfreak
approved these changes
Mar 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this has the benefit that it also works with empty sets and does not raise an error when trying to map empty arrays for names