Merge pull request #276 from rwaffen/update_outputs

fix: use filter_set and then the `.names` methode

Author: rwaffen

plans/patch_batch.pp

@@ -56,7 +56,7 @@
 
     # get nodes that are 'clean' from health check results
     $nodes_to_patch      = ($health_checks.filter_set |$item| { $item.value['state'] == 'clean' }).map |$n| { $n.target }
-    $health_check_failed = ($health_checks.filter_set |$item| { $item.status == 'failure' }).map |$n| { $n.name }.sort
+    $health_check_failed = ($health_checks.filter_set |$item| { $item.status == 'failure' }).names
 
     if $debug {
       out::message('patch_batch.pp: Nodes to patch after health check:')
@@ -85,22 +85,13 @@
     out::message($patching_result)
   }
 
-  $no_patches = $patching_result.ok_set.filter |$item| {
-    $item.value['packages_updated'].empty
-  }.map |$n| { $n.name }.sort
-
-  $with_patches = $patching_result.ok_set.filter |$item| {
-    ! $item.value['packages_updated'].empty
-  }.map |$n| { $n.name }.sort
-
-  $reboot_required = $patching_result.ok_set.filter |$item| {
-    $item.value['reboot_required'] == true
-  }.map |$n| { $n.name }.sort
-
-  $targets = get_targets($batch).map |$t| { $t.name }.sort
+  $no_patches      = $patching_result.ok_set.filter_set |$item| { $item.value['packages_updated'].empty }.names
+  $with_patches    = $patching_result.ok_set.filter_set |$item| { ! $item.value['packages_updated'].empty }.names
+  $reboot_required = $patching_result.ok_set.filter_set |$item| { $item.value['reboot_required'] == true }.names
+  $targets         = get_targets($batch).map |$t| { $t.name }.sort
 
   $output = {
-    failed              => $patching_result.error_set.map |$n| { $n.name }.sort,
+    failed              => $patching_result.error_set.names,
     health_check        => $run_health_check,
     health_check_failed => $health_check_failed,
     no_patches          => $no_patches,