Skip to content

Fix CGEventTap run loop source leak causing duplicate paste in iTerm2 #1030

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Copilot wants to merge 2 commits into
base: dev
Choose a base branch
from
+9 −4
Draft

Fix CGEventTap run loop source leak causing duplicate paste in iTerm2 #1030

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
896622d
Initial plan
Copilot Nov 16, 2025
b0d35ca
Fix CGEventTap memory leak causing double paste in iTerm2
Copilot Nov 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions Easydict/objc/EventMonitor/EZEventMonitor.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,7 @@ @interface EZEventMonitor ()
@property (nonatomic, assign) NSInteger currentAlertVolume;

@property (nonatomic, assign) CFMachPortRef eventTap;
@property (nonatomic, assign) CFRunLoopSourceRef eventTapRunLoopSource;

@property (nonatomic, assign) EZTriggerType frontmostAppTriggerType;
@property (nonatomic, assign) BOOL isPopButtonVisible;
Expand Down Expand Up @@ -235,9 +236,9 @@ - (void)monitorCGEventTap {
if (eventTap) {
// eventTap must not be NULL, otherwise it will crash.
CFRunLoopSourceRef runLoopSource = CFMachPortCreateRunLoopSource(kCFAllocatorDefault, eventTap, 0);
self.eventTapRunLoopSource = runLoopSource;
CFRunLoopAddSource(CFRunLoopGetCurrent(), runLoopSource, kCFRunLoopCommonModes);
CGEventTapEnable(eventTap, true);
CFRelease(runLoopSource);
}
}

Expand All @@ -256,9 +257,13 @@ - (void)stopCGEventTap {
// Stop and release the previously created event tap
if (self.eventTap) {
CGEventTapEnable(self.eventTap, false); // Disable the event tap
CFRunLoopSourceRef runLoopSource = CFMachPortCreateRunLoopSource(kCFAllocatorDefault, self.eventTap, 0);
CFRunLoopRemoveSource(CFRunLoopGetCurrent(), runLoopSource, kCFRunLoopCommonModes);
CFRelease(runLoopSource);

if (self.eventTapRunLoopSource) {
CFRunLoopRemoveSource(CFRunLoopGetCurrent(), self.eventTapRunLoopSource, kCFRunLoopCommonModes);
CFRelease(self.eventTapRunLoopSource);
self.eventTapRunLoopSource = NULL;
}

CFRelease(self.eventTap);
self.eventTap = NULL;
}
Expand Down