Fix CGEventTap run loop source leak causing duplicate paste in iTerm2#1030
Draft
Fix CGEventTap run loop source leak causing duplicate paste in iTerm2#1030
Conversation
Fixed a bug in stopCGEventTap() that was creating a new CFRunLoopSourceRef instead of properly removing the original one. This could cause the event tap to not be properly cleaned up, leading to duplicate key events in iTerm2. Co-authored-by: tisfeng <25194972+tisfeng@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix issue with double paste in iTerm2
Fix CGEventTap run loop source leak causing duplicate paste in iTerm2
Nov 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cmd+V in iTerm2 pastes clipboard content twice when Easydict is running. Root cause:
stopCGEventTap()created a newCFRunLoopSourceRefinstead of removing the original, leaving the event tap active after "stopping".Changes
CFRunLoopSourceRefineventTapRunLoopSourceproperty for proper lifecycle managementCFRelease()inmonitorCGEventTap()to keep source alivestopCGEventTap()to remove and release the stored sourceImpact
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.