feat(newton): skeleton NewtonSimulation(SimEngine) + config + factory registration#99
Open
cagataycali wants to merge 1 commit into
Open
feat(newton): skeleton NewtonSimulation(SimEngine) + config + factory registration#99cagataycali wants to merge 1 commit into
cagataycali wants to merge 1 commit into
Conversation
7aa29dc to
4e218b5
Compare
This was referenced Apr 21, 2026
Member
Author
45 tasks
19fd75d to
e7d61ae
Compare
… registration Add Newton GPU simulation backend stub implementing the SimEngine ABC. All methods raise NotImplementedError — actual implementations will follow in subsequent PRs (world lifecycle, step/action/obs, objects, diffsim). Changes: - strands_robots/simulation/newton/ — NewtonSimulation, NewtonConfig - tests/simulation/newton/ — 81 tests (config, factory, lazy import, simulation) - pyproject.toml — [newton] extra (warp-lang + newton-sim), excluded from [all] since newton-sim is not yet on PyPI - mypy overrides — added warp.* and newton.* to ignore list - Fixed method signatures to match SimEngine ABC (list_robots, robot_joint_names, get_observation, run_policy) after PR strands-labs#85 updated the base class
e7d61ae to
238f25e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR
Add Newton GPU simulation backend skeleton —
NewtonSimulation(SimEngine)with config, factory registration, and 81 tests. All methods raiseNotImplementedError; actual Newton API implementations follow in PRs 2–6.What changed
strands_robots/simulation/newton/__init__.pystrands_robots/simulation/newton/config.pyNewtonConfigdataclass (14 GPU-sim params)strands_robots/simulation/newton/simulation.pyNewtonSimulation(SimEngine)— full ABC impltests/simulation/newton/pyproject.toml[newton]extra, mypy overridesDesign decisions
warpandnewtonare only imported at instantiation time, not at module importSimulationFactory.create("newton")auto-discovers the backendNewtonConfigexposes all GPU-sim knobs (num_envs, device, solver, physics_dt, etc.)[all]—newton-simis not yet on PyPI; CI installs[all]without breakageMethod signatures aligned with SimEngine ABC (post-PR #85)
list_robots() -> list[str]robot_joint_names(robot_name) -> list[str]get_observation(robot_name, *, skip_images=False) -> dictrun_policy(robot_name, policy_provider, ..., policy_object, n_steps, max_steps, max_onframe_failures) -> dictTesting
238f25e)Part 1 of 7 in the Newton simulation backend series (#96)