fix: update vep wrappers to 8.0.0 to make env installable#402
fix: update vep wrappers to 8.0.0 to make env installable#402johanneskoester merged 2 commits intosnakemake-workflows:masterfrom
Conversation
WalkthroughWrapper version strings for VEP were updated to v8.0.0 in four Snakemake rules across two workflow files; no other logic, inputs/outputs, or control flow were changed. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes
Possibly related PRs
Suggested reviewers
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
workflow/rules/ref.smk (1)
137-137: Consider updating to v8.8.0 for consistency.The cache wrapper is updated to v8.0.0 while the plugins wrapper (line 148) and both annotate wrappers (workflow/rules/annotation.smk:24,52) are updated to v8.8.0. Is there a specific reason for keeping the cache at v8.0.0?
If v8.8.0 is available for the cache wrapper and compatible, consider updating for version consistency:
- "v8.0.0/bio/vep/cache" + "v8.8.0/bio/vep/cache"Alternatively, verify that v8.0.0 cache is compatible with v8.8.0 annotate/plugins wrappers.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
workflow/rules/annotation.smk(2 hunks)workflow/rules/ref.smk(2 hunks)
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2024-11-25T12:34:09.018Z
Learnt from: johanneskoester
Repo: snakemake-workflows/dna-seq-varlociraptor PR: 338
File: workflow/rules/candidate_calling.smk:86-87
Timestamp: 2024-11-25T12:34:09.018Z
Learning: In this workflow, the grouping of variant calling rules is intentional, and not all related variant calling rules need to be grouped under "calling".
Applied to files:
workflow/rules/annotation.smk
🔇 Additional comments (2)
workflow/rules/annotation.smk (1)
52-52: Consistent with the other annotation rule.Both VEP annotation rules now use v8.8.0, which maintains consistency.
workflow/rules/ref.smk (1)
148-148: Version update looks good.The plugins wrapper is updated to v8.8.0, consistent with the annotate wrappers.
fa7d314
into
snakemake-workflows:master
Summary by CodeRabbit