Skip to content

app/product-feed: allow to use custom s3 provider #2232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
djkato wants to merge 6 commits into
base: main
Choose a base branch
from

Merge branch 'main' into product-feed-custom-s3-provider

3371518
Select commit
Loading
Failed to load commit list.
Open

app/product-feed: allow to use custom s3 provider #2232

Merge branch 'main' into product-feed-custom-s3-provider
3371518
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Feb 23, 2026 in 1s

30.89% (-5.71%) compared to 18f0845

View this Pull Request on Codecov

30.89% (-5.71%) compared to 18f0845

Details

Codecov Report

❌ Patch coverage is 3.17460% with 61 lines in your changes missing coverage. Please review.
✅ Project coverage is 30.89%. Comparing base (18f0845) to head (3371518).

Files with missing lines Patch % Lines
...odules/app-configuration/s3-configuration-form.tsx 0.00% 38 Missing ⚠️
...src/modules/file-storage/s3/check-bucket-access.ts 0.00% 15 Missing ⚠️
...ules/app-configuration/app-configuration.router.ts 0.00% 4 Missing ⚠️
...-storage/s3/create-s3-client-from-configuration.ts 0.00% 4 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (18f0845) and HEAD (3371518). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (18f0845) HEAD (3371518)
avatax 1 0
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2232      +/-   ##
==========================================
- Coverage   36.59%   30.89%   -5.71%     
==========================================
  Files         964      754     -210     
  Lines       63579    49516   -14063     
  Branches     3097     2479     -618     
==========================================
- Hits        23268    15298    -7970     
+ Misses      39947    33937    -6010     
+ Partials      364      281      -83

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
View more details on Codecov