app/product-feed: allow to use custom s3 provider#2232
app/product-feed: allow to use custom s3 provider#2232djkato wants to merge 6 commits intosaleor:mainfrom
Conversation
🦋 Changeset detectedLatest commit: 3371518 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
@djkato is attempting to deploy a commit to the Saleor Commerce Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
tests and linters are failing |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2232 +/- ##
==========================================
- Coverage 36.59% 30.89% -5.71%
==========================================
Files 964 754 -210
Lines 63579 49516 -14063
Branches 3097 2479 -618
==========================================
- Hits 23268 15298 -7970
+ Misses 39947 33937 -6010
+ Partials 364 281 -83
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Yo, is the codecov blocking? What do I do to fix it? |
| "MANIFEST_APP_ID", | ||
| "FILE_APL_PATH" | ||
| "FILE_APL_PATH", | ||
| "APP_API_BASE_URL" |
Scope of the PR
change the s3 configuration form of app/product-feed to be more generic, to allow custom endpoints, regions and allow to toggle path style endpoints.
Checklist