Skip to content

app/product-feed: allow to use custom s3 provider#2232

Open
djkato wants to merge 6 commits intosaleor:mainfrom
djkato:product-feed-custom-s3-provider
Open

app/product-feed: allow to use custom s3 provider#2232
djkato wants to merge 6 commits intosaleor:mainfrom
djkato:product-feed-custom-s3-provider

Conversation

@djkato
Copy link
Copy Markdown

@djkato djkato commented Feb 12, 2026

Scope of the PR

change the s3 configuration form of app/product-feed to be more generic, to allow custom endpoints, regions and allow to toggle path style endpoints.

Checklist

@djkato djkato requested a review from a team as a code owner February 12, 2026 22:42
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Feb 12, 2026

🦋 Changeset detected

Latest commit: 3371518

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
saleor-app-products-feed Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link
Copy Markdown

vercel Bot commented Feb 12, 2026

@djkato is attempting to deploy a commit to the Saleor Commerce Team on Vercel.

A member of the Team first needs to authorize it.

Comment thread apps/products-feed/src/modules/app-configuration/s3-configuration-form.tsx Outdated
Comment thread apps/products-feed/src/modules/app-configuration/s3-configuration-form.tsx Outdated
djkato added a commit to djkato/saleor-docs that referenced this pull request Feb 13, 2026
@djkato djkato requested a review from lkostrowski February 13, 2026 12:52
@vercel
Copy link
Copy Markdown

vercel Bot commented Feb 13, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
saleor-app-products-feed Error Error Feb 23, 2026 7:57am

Request Review

@lkostrowski
Copy link
Copy Markdown
Member

tests and linters are failing

@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 17, 2026

Codecov Report

❌ Patch coverage is 3.17460% with 61 lines in your changes missing coverage. Please review.
✅ Project coverage is 30.89%. Comparing base (18f0845) to head (3371518).

Files with missing lines Patch % Lines
...odules/app-configuration/s3-configuration-form.tsx 0.00% 38 Missing ⚠️
...src/modules/file-storage/s3/check-bucket-access.ts 0.00% 15 Missing ⚠️
...ules/app-configuration/app-configuration.router.ts 0.00% 4 Missing ⚠️
...-storage/s3/create-s3-client-from-configuration.ts 0.00% 4 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (18f0845) and HEAD (3371518). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (18f0845) HEAD (3371518)
avatax 1 0
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2232      +/-   ##
==========================================
- Coverage   36.59%   30.89%   -5.71%     
==========================================
  Files         964      754     -210     
  Lines       63579    49516   -14063     
  Branches     3097     2479     -618     
==========================================
- Hits        23268    15298    -7970     
+ Misses      39947    33937    -6010     
+ Partials      364      281      -83     
Flag Coverage Δ
avatax ?
cms 16.87% <ø> (ø)
domain 100.00% <ø> (ø)
dynamo-config-repository 79.29% <ø> (ø)
errors 91.66% <ø> (ø)
logger 28.81% <ø> (ø)
np-atobarai 72.62% <ø> (ø)
products-feed 5.65% <3.17%> (-0.01%) ⬇️
search 29.76% <ø> (ø)
segment 30.85% <ø> (ø)
shared 37.35% <ø> (ø)
smtp 33.95% <ø> (ø)
stripe 70.62% <ø> (ø)
webhook-utils 11.02% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@djkato
Copy link
Copy Markdown
Author

djkato commented Feb 20, 2026

Yo, is the codecov blocking? What do I do to fix it?

"MANIFEST_APP_ID",
"FILE_APL_PATH"
"FILE_APL_PATH",
"APP_API_BASE_URL"
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@djkato duplicated line with L9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants