Skip to content

Revert "LLVM 23: Run AssignGUIDPass in some places"#157365

Open
zmodem wants to merge 1 commit into
rust-lang:mainfrom
zmodem:revert_assign_guids
Open

Revert "LLVM 23: Run AssignGUIDPass in some places"#157365
zmodem wants to merge 1 commit into
rust-lang:mainfrom
zmodem:revert_assign_guids

Conversation

@zmodem
Copy link
Copy Markdown
Contributor

@zmodem zmodem commented Jun 3, 2026

This reverts commit cdb73bb.

The LLVM side change was reverted.

@rustbot rustbot added A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. PG-exploit-mitigations Project group: Exploit mitigations S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jun 3, 2026
@zmodem
Copy link
Copy Markdown
Contributor Author

zmodem commented Jun 3, 2026

@rustbot label llvm-main

@rustbot rustbot added the llvm-main Marks PRs that are making Rust work with LLVM main (this label is consumed by CI tooling) label Jun 3, 2026
@zmodem zmodem mentioned this pull request Jun 3, 2026
Merged
@rust-bors

This comment has been minimized.

Sign in to view
@zmodem zmodem force-pushed the revert_assign_guids branch from d2bd2c4 to 4919940 Compare June 5, 2026 07:29
@cuviper
Copy link
Copy Markdown
Member

cuviper commented Jun 5, 2026

If you want to take this out of draft, I'll approve it. We can always add it again if LLVM brings it back.

@zmodem zmodem marked this pull request as ready for review June 6, 2026 06:10
@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented Jun 6, 2026

Some changes occurred in tests/codegen-llvm/sanitizer

cc @rcvalle

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 6, 2026
@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented Jun 6, 2026

r? @ShoyuVanilla

rustbot has assigned @ShoyuVanilla.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: compiler
  • compiler expanded to 73 candidates
  • Random selection from 20 candidates

@zmodem
Copy link
Copy Markdown
Contributor Author

zmodem commented Jun 6, 2026

r? @cuviper

@rustbot rustbot assigned cuviper and unassigned ShoyuVanilla Jun 6, 2026
cuviper
cuviper approved these changes Jun 6, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@cuviper cuviper left a comment •
edited by rustbot
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bors r+ rollup

View changes since this review

@rust-bors
Copy link
Copy Markdown
Contributor

rust-bors Bot commented Jun 6, 2026

📌 Commit 4919940 has been approved by cuviper

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 6, 2026
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Jun 6, 2026
@JonathanBrouwer
Rollup merge of rust-lang#157365 - zmodem:revert_assign_guids, r=cuviper
a2990fd 
Revert "LLVM 23: Run AssignGUIDPass in some places"

This reverts commit cdb73bb.

The LLVM side change was reverted.
@JonathanBrouwer JonathanBrouwer mentioned this pull request Jun 6, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cuviper cuviper cuviper approved these changes

Assignees

@cuviper cuviper

Labels

A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. llvm-main Marks PRs that are making Rust work with LLVM main (this label is consumed by CI tooling) PG-exploit-mitigations Project group: Exploit mitigations S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@zmodem @cuviper @rustbot @ShoyuVanilla