Rollup of 8 pull requests#157525
Closed
JonathanBrouwer wants to merge 17 commits into
Closed
Conversation
When a method call fails to resolve, the suggestion machinery probes all traits for a method with the same name and builds a trait reference for the providing trait to detect duplicate trait items coming from multiple crate versions. It passed only the receiver type as the single argument, which is correct only for traits whose sole generic parameter is `Self`. For a trait with further parameters (for example `Borrow<Borrowed>`), or when the receiver type is unknown, the argument list no longer matched the trait's generics and tripped the `debug_assert_args_compatible` assertion, producing an ICE. Build the argument list with `GenericArgs::for_item` instead, using the receiver type for `Self` when known and fresh inference variables for the remaining parameters.
This reverts commit cdb73bb.
…tests on Windows So that we don't get a bunch of console windows spawned by the debugger processes.
Assisted-by: OpenAI:gpt-5.5 Co-authored-by: Ayuse <ayodeleoluwasina@gmail.com> Signed-off-by: Embers-of-the-Fire <stellarishs@163.com>
…t-run-pass, r=Embers-of-the-Fire test(chore): audit `//@ run-pass` in ui tests Part of work for rust-lang#154158.
…eLapkin add `extern "tail"` calling convention Maps to LLVM's `tailcc` and hence inherits all its problems. This calling convention at least compiles on: - `x86_64` - `aarch64` It also compiles on - `s390x` - `loongarch64` But I've been told by target maintainers that this is kind of unintentional, and it's not tested in LLVM. For most backends LLVM does not have support and fails loudly.
…it-extra-generics-ice, r=chenyukang diagnostics: Fix ICE building a trait ref in method suggestions Fixes rust-lang#157189 When a method call doesn't resolve, the no-method-found diagnostic probes every trait for one with a same-named method and builds a trait ref for it to spot trait items duplicated across crate versions. It only ever passed the receiver as the single argument, which works only when the trait's one generic is `Self`. Call `.borrow()` on something and the probe finds `Borrow`, whose extra `Borrowed` parameter leaves the args out of step with the trait's generics, so `debug_assert_args_compatible` fires. Same crash when the receiver type isn't known and there are zero args. Now the args come from `GenericArgs::for_item`: the receiver fills `Self` when we have it, fresh inference variables cover the rest.
…ystem-hack, r=Kobzol compiletest: inject `#![windows_subsystem = "windows"]` to debuginfo tests on Windows So that we don't get a bunch of console windows spawned by the debuggees. r? @Kobzol (or bootstrap/compiler)
…BurntSushi
Rename `SyncView::{as_pin => as_pin_ref}`
This addresses the resolution of a naming concern from rust-lang#98407.
r? BurntSushi
…eyouxu
Add infallible primitive type lookups to template arg resolver
Fixes a regression that seem to come from LLDB 22 where looking up primitive types by name on MSVC no longer works. Container types use type name lookups to resolve generics, so it causes container types (e.g. `Vec<i32>`) to fail to create their child values.
Before:
```
(lldb) v vec_v
(alloc::vec::Vec<i32,alloc::alloc::Global>) vec_v = size=5 {}
(lldb) v vec_v[0]
error: <user expression 0>:1:6: array index 0 is not valid for "(Vec<i32,alloc::alloc::Global>) vec_v"
1 | vec_v[0]
| ^
```
After:
```
(lldb) v vec_v
(alloc::vec::Vec<i32,alloc::alloc::Global>) vec_v = size=5 {
[0] = 10
[1] = 20
[2] = 30
[3] = 40
[4] = 50
}
(lldb) v vec_v[0]
(long) vec_v[0] = 10
```
This patch maps the type name to its `eBasicType` equivalent (i.e. the LLDB enum for primitive types) and looks up the type based on that. AFAIK, `eBasicType` lookups are 100% infallible. Even if the primitive type somehow isn't in the debug info, `TypeSystemClang` will invent the appropriate `SBType` object for it.
This isn't a major blocker for the test suite rework, but it does prevent me from blessing tests with container types on MSVC unless I downgrade to LLDB 21.
r? @jieyouxu, @Kobzol
Revert "LLVM 23: Run AssignGUIDPass in some places" This reverts commit cdb73bb. The LLVM side change was reverted.
…s-as-struct, r=ShoyuVanilla Convert `QueryRegionConstraint` into a struct as per in fixme
rustbot
added
A-compiletest
Contributor
Author
Contributor
rust-bors
Bot
added
the
S-waiting-on-bors
rust-bors
Bot
removed
the
S-waiting-on-review
Contributor
|
⌛ Trying commit 85b3fd3 with merge ff5ff6d… To cancel the try build, run the command Workflow: https://github.com/rust-lang/rust/actions/runs/27057698274 |
rust-bors Bot
pushed a commit
that referenced
this pull request
Jun 6, 2026
Rollup of 8 pull requests try-job: dist-various-1 try-job: test-various try-job: x86_64-gnu-aux try-job: x86_64-gnu-llvm-21-3 try-job: x86_64-msvc-1 try-job: aarch64-apple try-job: x86_64-mingw-1 try-job: i686-msvc-2
Collaborator
|
The job Click to see the possible cause of the failure (guessed by this bot) |
rust-bors
Bot
added
the
S-waiting-on-author
Contributor
|
PR #154254, which is a member of this rollup, was unapproved. This rollup was thus unapproved. |
rust-bors
Bot
removed
the
S-waiting-on-bors
rustbot
removed
the
S-waiting-on-author
Contributor
Author
|
@bors try cancel |
Contributor
|
Try build cancelled. Cancelled workflows: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
//@ run-passin ui tests #154254 (test(chore): audit//@ run-passin ui tests)extern "tail"calling convention #157016 (addextern "tail"calling convention)#![windows_subsystem = "windows"]to debuginfo tests on Windows #157488 (compiletest: inject#![windows_subsystem = "windows"]to debuginfo tests on Windows)SyncView::{as_pin => as_pin_ref}#157521 (RenameSyncView::{as_pin => as_pin_ref})QueryRegionConstraintinto a struct #157494 (ConvertQueryRegionConstraintinto a struct)Failed merges:
r? @ghost
Create a similar rollup