Skip to content

RHSTOR-7964: Add consumer_name label validation for provider-mode metrics#15127

Open
suchita-g wants to merge 1 commit into
red-hat-storage:masterfrom
suchita-g:RHSTOR-7964-consumer_name_label_on_provider_metric
Open

RHSTOR-7964: Add consumer_name label validation for provider-mode metrics#15127
suchita-g wants to merge 1 commit into
red-hat-storage:masterfrom
suchita-g:RHSTOR-7964-consumer_name_label_on_provider_metric

Conversation

@suchita-g
Copy link
Copy Markdown
Contributor

  • Add ocs_metrics_exporter_helpers module with scrape/parse utilities for curling /metrics from inside the exporter pod (HTTPS+bearer token on 8443).
  • Add parameterized test test_consumer_name_label_on_provider_metric verifies following consumer_name label is present on per-client metrics on provider clusters with onboarded consumers.
    • ocs_rbd_pv_metadata,
    • ocs_rbd_children_count,
    • ocs_rbd_mirror_image_state,
    • ocs_pool_mirroring_image_health,
    • ocs_pool_mirroring_status,
    • ocs_rbd_client_blocklisted

…rics

- Add ocs_metrics_exporter_helpers module with scrape/parse utilities for
  curling /metrics from inside the exporter pod (HTTPS+bearer token on 8443).
- Add parameterized test test_consumer_name_label_on_provider_metric
  verifies following consumer_name label is present on per-client metrics
  on provider clusters with onboarded consumers.
  - ocs_rbd_pv_metadata,
  - ocs_rbd_children_count,
  - ocs_rbd_mirror_image_state,
  - ocs_pool_mirroring_image_health,
  - ocs_pool_mirroring_status,
  - ocs_rbd_client_blocklisted

Signed-off-by: suchita-g <sgatfane@redhat.com>
@suchita-g suchita-g requested review from a team as code owners May 13, 2026 03:41
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented May 13, 2026

@suchita-g: This pull request references RHSTOR-7964 which is a valid jira issue.

Details

In response to this:

  • Add ocs_metrics_exporter_helpers module with scrape/parse utilities for curling /metrics from inside the exporter pod (HTTPS+bearer token on 8443).
  • Add parameterized test test_consumer_name_label_on_provider_metric verifies following consumer_name label is present on per-client metrics on provider clusters with onboarded consumers.
  • ocs_rbd_pv_metadata,
  • ocs_rbd_children_count,
  • ocs_rbd_mirror_image_state,
  • ocs_pool_mirroring_image_health,
  • ocs_pool_mirroring_status,
  • ocs_rbd_client_blocklisted

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@pull-request-size pull-request-size Bot added the size/L PR that changes 100-499 lines label May 13, 2026
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented May 13, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: suchita-g

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@suchita-g suchita-g self-assigned this May 13, 2026
@suchita-g
Copy link
Copy Markdown
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/L PR that changes 100-499 lines Squad/Blue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants