Skip to content

Add tier1 post-upgrade test to verify the existence of noobaa prometheus ruels#15121

Open
sagihirshfeld wants to merge 1 commit into
red-hat-storage:masterfrom
sagihirshfeld:test-noobaa-prometheus-rules
Open

Add tier1 post-upgrade test to verify the existence of noobaa prometheus ruels#15121
sagihirshfeld wants to merge 1 commit into
red-hat-storage:masterfrom
sagihirshfeld:test-noobaa-prometheus-rules

Conversation

@sagihirshfeld
Copy link
Copy Markdown
Contributor

Summary

  • Adds test_noobaa_prometheus_rules_exist to verify the
    noobaa-prometheus-rules PrometheusRule CR exists and contains rule groups
  • Marked tier1 + post_upgrade so it runs in post-upgrade CI pipelines

Motivation

A stakeholder reported missing NooBaa Prometheus alerting rules after upgrading
ODF 4.21 → 4.22. Investigation confirmed we had zero post-upgrade test coverage
for PrometheusRule CR existence.

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Signed-off-by: Sagi Hirshfeld <shirshfe@redhat.com>
@sagihirshfeld sagihirshfeld self-assigned this May 12, 2026
@sagihirshfeld sagihirshfeld added Needs Testing Run tests and provide logs link MCG Multi Cloud Gateway / NooBaa related issues Squad/Blue Squad/Red labels May 12, 2026
@pull-request-size pull-request-size Bot added the size/S PR that changes 10-29 lines label May 12, 2026
@sagihirshfeld
Copy link
Copy Markdown
Contributor Author

/cherry-pick release-4.21

@openshift-cherrypick-robot
Copy link
Copy Markdown
Collaborator

@sagihirshfeld: once the present PR merges, I will cherry-pick it on top of release-4.21 in a new PR and assign it to you.

Details

In response to this:

/cherry-pick release-4.21

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Copy Markdown

@ocs-ci ocs-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR validation on existing cluster

Cluster Name: shirshfe-22ibm09
Cluster Configuration: conf/deployment/ibmcloud/ipi_3az_rhcos_3m_3w.yaml
PR Test Suite:
PR Test Path: tests/functional/object/mcg/test_endpoint_network_disruption.py
Additional Test Params: --skip-rpm-go-version-collection
OCP VERSION: 4.22
OCS VERSION: 4.22
tested against branch: master

Job FAILED (installation failed, tests not executed).

Copy link
Copy Markdown

@ocs-ci ocs-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR validation on existing cluster

Cluster Name: shirshfe-22ibm09
Cluster Configuration: conf/deployment/ibmcloud/ipi_3az_rhcos_3m_3w.yaml
PR Test Suite:
PR Test Path: tests/functional/monitoring/prometheus/alerts/test_noobaa.py::test_noobaa_prometheus_rules_exist
Additional Test Params: --skip-rpm-go-version-collection
OCP VERSION: 4.22
OCS VERSION: 4.22
tested against branch: master

Job PASSED.

@sagihirshfeld sagihirshfeld added Verified Mark when PR was verified and log provided and removed Needs Testing Run tests and provide logs link labels May 12, 2026
@sagihirshfeld sagihirshfeld marked this pull request as ready for review May 12, 2026 09:44
@sagihirshfeld sagihirshfeld requested a review from a team as a code owner May 12, 2026 09:44
Copy link
Copy Markdown
Contributor

@ypersky1980 ypersky1980 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented May 12, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sagihirshfeld, ypersky1980

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm MCG Multi Cloud Gateway / NooBaa related issues size/S PR that changes 10-29 lines Squad/Blue Squad/Red Verified Mark when PR was verified and log provided

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants