Fix mon pod selection on LSO deployments in test_mon_data_avail_warn#14707
Merged
vavuthu merged 3 commits intoApr 22, 2026
Conversation
The LSO code path used ceph_daemon_id label to find the mon pod, but this label is shared between mon and mgr pods (both have ceph_daemon_id=a). When the mgr pod was returned first by the API, the test selected it instead of the mon pod, causing mon_suffix=None and mkdir failure. Replace the LSO-specific pod lookup with get_mon_pods() which uses the unambiguous app=rook-ceph-mon label. The worker node for the LSO dd path is now derived from the selected mon pod's spec.nodeName. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Amrita Mahapatra <49347640+amr1ta@users.noreply.github.com>
On LSO, df -Th | grep /etc/hosts returned empty because df shows mount
points not file paths, causing IndexError. Use df -Th with the actual
mon data path (/var/lib/rook/mon-{suffix}/data) via oc debug on the
worker node. Also switch non-LSO to use df -Th {path} directly instead
of grep for reliability.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Signed-off-by: Amrita Mahapatra <49347640+amr1ta@users.noreply.github.com>
pull-request-size
Bot
added
size/M
vavuthu
previously approved these changes
Mar 18, 2026
Writing 1GB of random data via oc debug can exceed the default 300s timeout, especially on later iterations when the disk is nearly full. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Amrita Mahapatra <49347640+amr1ta@users.noreply.github.com>
Contributor
Author
ebenahar
approved these changes
Apr 6, 2026
yitzhak12
approved these changes
Apr 15, 2026
suchita-g
approved these changes
Apr 22, 2026
vavuthu
approved these changes
Apr 22, 2026
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: amr1ta, ebenahar, suchita-g, vavuthu, yitzhak12 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Contributor
Author
|
/cherry-pick release-4.21 |
Collaborator
|
@amr1ta: new pull request created: #15135 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
workloads_dir_setupusedceph_daemon_idlabel to find the mon pod, but this label is shared between mon and mgr pods (e.g., bothrook-ceph-mon-aandrook-ceph-mgr-ahaveceph_daemon_id=a)mon_suffix=Noneandmkdir /var/lib/ceph/mon/ceph-None/workloadsfailureget_mon_pods()which uses the unambiguousapp=rook-ceph-monlabelspec.nodeNameRoot Cause
ReportPortal: https://reportportal-ocs4.apps.dno.ocp-hub.prod.psi.redhat.com/ui/#ocs/launches/all/44404/2024569/2024879/log
Platform: vSphere UPI LSO