-
Notifications
You must be signed in to change notification settings - Fork 78
Support Sparkfun ICM20948 Breakout board (SPI only, I2C TBD) #68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from 1 commit
3895d95
e896acf
527d8b1
8bd66ff
1ded436
c258480
42736b0
176314e
9fa51c6
af6d8bf
b04db65
860abb5
86d07e9
21d4588
726d540
c6ed36a
0088470
7b99f7e
af09253
fa4f032
73232a7
bec9795
f77ef9a
1a3495d
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
|
Owner
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Let's put this in a new PR - I think this will need some additional considerations... Some (random) thoughts: Rather add a new imu_gizmo mf_ICM20948_6DOF than a new parameter. (I try to keep number of parameters as low as possible) If adding a parameter: New config params should be added at the end of the array - this allows users to upgrade without eeprom corruption. I would use value 0 or 1 (not <=0 or 1) Default value 1 makes more sense to me - use mag if we have it. Rather name the param and related vars imu_use_mag, and reserve the "has" properties for driver capabilities. Not consistent with current 9dof drivers...
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yeah, not consistent with existing drivers - made it use_mag and moved to bottom. Only really used by ICM20948 for now, could be used by MPU9250 if it supports 6DOF. But left others alone to have minimal code changes.
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. In the meantime, my quadcopter crashed and burned badly - need to debug it, it stopped listening to IBUS and didn't automatically disarm itself when it lost contact!
Owner
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
ouch!
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I seemed to have lost some code when I split Icm20948 and ibus code so putting it back - related to calibration and quaternions |
|
atinm marked this conversation as resolved.
|
|
atinm marked this conversation as resolved.
|
Uh oh!
There was an error while loading. Please reload this page.