Conversation
2fb84a9 to
4a75946
Compare
henryiii
left a comment
There was a problem hiding this comment.
As soon as we are sure the next version is a minor version bump, I think this should go in.
2887863 to
7f5d182
Compare
|
I rebased to fix the conflict with
The removal is now approximately 1 month away. I'm leaning towards the first option for cp313t. |
|
If I get a chance to work on multi-wheel output (I might in 1-2 weeks), that would be a good feature for a new minor version. |
|
Given the only functionality change here is the removal of cpython-freethreading from |
Free-Threading Python 3.13 was experimental. Now that Python 3.14 has been released with explicit support, we can schedule removal of Python 3.13 free-threading.
7f5d182 to
b06178f
Compare
|
I rebased / forced push with fixes to tests in order to get proper typing in there. |
|
Hi, this seems perfectly fine in principle, however the timeline here seems very rushed. There are a lot of projects using this in both regular CI and in release scripts. Even when An announcement on DPO and a slightly longer timeline so removals from CI across O(100) projects can be done systematically would be helpful. I now realize that gh-2683 has been open for several months, but that had next to no visibility. If I didn't know about it (working on both Python packaging and free-threading), then I'm pretty sure that the vast majority of package authors that use this feature won't know yet. |
|
We are starting with a deprecation warning, which should increase visibility. |
|
Yes, that just appeared. My comment is about the timeline for removal - |
|
You can keep the old cibuildwheel, which will be pinned to an old manylinux, which will still have it. Though then you can't do beta one. I think this would be doable for NumPy; the dev branch could drop 3.13t and add the beta, but it wouldn't release till rc1, which is much further away, and probably fine for 3.13t? Remember that was always experimental, unlike 3.14t. I could see an argument that keeping it around a bit longer so that it doesn't collide with the addition of 3.15 - but I don't make decisions in manylinux. ;) |
|
@rgommers thanks for chiming in. Sorry for causing a headache.
Just so that I understand, you'd rather that numpy dropped 313t before cibuildwheel? Or you'd rather that projects downstream of numpy had a chance to drop 313t before numpy is forced to? |
Yes, this. It's best to go in reverse order through the whole dependency tree, to avoid getting builds from source (which will then likely fail). And sometimes PRs take a while before getting merged, some maintainers have questions, etc. We'll have to go through a good part of what's tracked at https://py-free-threading.github.io/tracking/. CI failures aren't the end of the world, but we spent a lot of time asking maintainers to pretty please accept adding cp313t wheels, so I'd rather minimize any friction to not burn any goodwill. |
Free-Threading Python 3.13 was experimental.
Now that Python 3.14 has been released with explicit support, we can schedule removal of Python 3.13 free-threading.
towards #2683
see also #2684