Skip to content

Drop 3.13t support#1326

Open
ngoldbaum wants to merge 5 commits intoaio-libs:masterfrom
ngoldbaum:rm-3.13t-builds
Open

Drop 3.13t support#1326
ngoldbaum wants to merge 5 commits intoaio-libs:masterfrom
ngoldbaum:rm-3.13t-builds

Conversation

@ngoldbaum
Copy link
Copy Markdown

What do these changes do?

See the note at https://cibuildwheel.pypa.io/en/stable/changelog/#v341 and pypa/cibuildwheel#2787.

The cpython-freethreading option will be removed in the next release of cibuildwheel.

I'm going through repositories on GitHub that enable this option and sending in PRs to disable it. Happy to answer questions about this. I also took the opportunity to drop 3.13t CI.

If you're curious why 3.13t support is going away so soon, see https://py-free-threading.github.io/ci/#building-free-threaded-wheels-with-cibuildwheel for further guidance.

Are there changes in behavior for the user?

The next release will not include cp313t wheel builds.

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes

@ngoldbaum ngoldbaum requested a review from asvetlov as a code owner April 22, 2026 20:51
@ngoldbaum ngoldbaum requested a review from webknjaz as a code owner April 22, 2026 20:51
@psf-chronographer psf-chronographer Bot added the bot:chronographer:provided There is a change note present in this PR label Apr 22, 2026
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented Apr 22, 2026

Merging this PR will not alter performance

✅ 245 untouched benchmarks


Comparing ngoldbaum:rm-3.13t-builds (ebc5d3d) with master (70fcaba)

Open in CodSpeed

@Vizonex
Copy link
Copy Markdown
Member

Vizonex commented Apr 23, 2026

@ngoldbaum Glad to see you here, seems some other people might be busy so I'll help you with the reviewing process.

Copy link
Copy Markdown
Member

@Vizonex Vizonex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All of this looks good might need to add a comment or two about why 3.13t is being removed but other than that I approve of this pull request.

Copy link
Copy Markdown
Member

@Vizonex Vizonex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That should be good enough now.

@Vizonex Vizonex self-requested a review April 24, 2026 21:30
Copy link
Copy Markdown
Member

@Vizonex Vizonex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Waiting for feedback about the changes I let everyone on the matrix know that a workflow was left hanging.

Copy link
Copy Markdown
Member

@webknjaz webknjaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from the change note, looks good. I'll wait for Nick and Sam to take a look before proceeding.

Comment thread CHANGES/1326.breaking.rst
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you symlink think to packaging? Also, I'm not sure if this counts as breaking.

cc @Dreamsorcerer @bdraco WDYT?

Comment thread CHANGES/1326.breaking.rst Outdated
Copy link
Copy Markdown
Member

@bdraco bdraco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once other comments are addressed. clearly 3.13t was not ready for production use so removing wheels is reasonable

Co-authored-by: 🇺🇦 Sviatoslav Sydorenko (Святослав Сидоренко) <wk.cvs.github@sydorenko.org.ua>
@ngoldbaum
Copy link
Copy Markdown
Author

Sorry for taking two weeks to click the button! I think this is ready now.

@codecov
Copy link
Copy Markdown

codecov Bot commented May 8, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.86%. Comparing base (637ffa9) to head (ebc5d3d).
⚠️ Report is 8 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1326      +/-   ##
==========================================
- Coverage   99.86%   99.86%   -0.01%     
==========================================
  Files          28       28              
  Lines        3607     3602       -5     
  Branches      265      265              
==========================================
- Hits         3602     3597       -5     
  Misses          3        3              
  Partials        2        2              
Flag Coverage Δ
CI-GHA 99.86% <ø> (-0.01%) ⬇️
pytest 99.86% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Vizonex
Copy link
Copy Markdown
Member

Vizonex commented May 9, 2026

Sorry for taking two weeks to click the button! I think this is ready now.

Good because we were worried that you just left on an hiatus, if I don't see anything new needing to be changed I'll request for this PR to be merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bot:chronographer:provided There is a change note present in this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants