Skip to content

Add type annotations for instance attributes in shell_completion #3455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jorenham wants to merge 3 commits into
base: stable
Choose a base branch
from
+14 −9
Open

Add type annotations for instance attributes in shell_completion #3455

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
37aa0c6
Fix dev version in 8.4.1
wallstreetio May 17, 2026
c9e9413
Fix dev version 8.4.1 (#3446)
Rowlando13 May 17, 2026
49024c1
Add type annotations for instance attributes in `shell_completion`
jorenham May 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CHANGES.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
.. currentmodule:: click

Version 8.4.dev
Version 8.4.1
------------------

Unreleased
Expand Down
2 changes: 1 addition & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[project]
name = "click"
version = "8.4.dev"
version = "8.4.1.dev"
description = "Composable command line interface toolkit"
readme = "README.md"
license = "BSD-3-Clause"
Expand Down
17 changes: 11 additions & 6 deletions src/click/shell_completion.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -225,6 +225,11 @@ class ShellComplete:
be provided by subclasses.
"""

cli: Command
ctx_args: cabc.MutableMapping[str, t.Any]
Copy link
Copy Markdown
Collaborator

@AndreasBackx AndreasBackx May 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should perhaps improve this later, but out of scope for this PR.

prog_name: str
complete_var: str

def __init__(
self,
cli: Command,
Expand Down Expand Up @@ -308,8 +313,8 @@ def complete(self) -> str:
class BashComplete(ShellComplete):
"""Shell completion for Bash."""

name = "bash"
source_template = _SOURCE_BASH
name: t.ClassVar[str] = "bash"
source_template: t.ClassVar[str] = _SOURCE_BASH

@staticmethod
def _check_version() -> None:
Expand Down Expand Up @@ -367,8 +372,8 @@ def format_completion(self, item: CompletionItem) -> str:
class ZshComplete(ShellComplete):
"""Shell completion for Zsh."""

name = "zsh"
source_template = _SOURCE_ZSH
name: t.ClassVar[str] = "zsh"
source_template: t.ClassVar[str] = _SOURCE_ZSH

def get_completion_args(self) -> tuple[list[str], str]:
cwords = split_arg_string(os.environ["COMP_WORDS"])
Expand Down Expand Up @@ -403,8 +408,8 @@ def format_completion(self, item: CompletionItem) -> str:
class FishComplete(ShellComplete):
"""Shell completion for Fish."""

name = "fish"
source_template = _SOURCE_FISH
name: t.ClassVar[str] = "fish"
source_template: t.ClassVar[str] = _SOURCE_FISH

def get_completion_args(self) -> tuple[list[str], str]:
cwords = split_arg_string(os.environ["COMP_WORDS"])
Expand Down
2 changes: 1 addition & 1 deletion uv.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading