Add type annotations for instance attributes in shell_completion#3455
Open
jorenham wants to merge 3 commits into
Open
Add type annotations for instance attributes in shell_completion#3455jorenham wants to merge 3 commits into
shell_completion#3455jorenham wants to merge 3 commits into
Conversation
This was referenced May 18, 2026
AndreasBackx
approved these changes
May 22, 2026
Collaborator
AndreasBackx
left a comment
AndreasBackx
left a comment
There was a problem hiding this comment.
Just remove the version change and like other PR rebase on main instead perhaps?
| """ | ||
|
|
||
| cli: Command | ||
| ctx_args: cabc.MutableMapping[str, t.Any] |
Collaborator
There was a problem hiding this comment.
We should perhaps improve this later, but out of scope for this PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here's another one like #3422, #3451, #3453, and #3454 (+0.43% type coverage).
This time, I somehow managed to keep myself from going out of scope, even though I saw a bunch of opportunities for improvement here in
click.shell_completion. I'll address those in a follow-up (sorry @ reviewers, but it's for a good cause).