Add type annotations for instance attributes in exceptions#3453
Open
jorenham wants to merge 3 commits into
Open
Add type annotations for instance attributes in exceptions#3453jorenham wants to merge 3 commits into
exceptions#3453jorenham wants to merge 3 commits into
Conversation
This was referenced May 18, 2026
kdeldycke
requested review from
AndreasBackx,
Rowlando13 and
davidism
and removed request for
Rowlando13
AndreasBackx
approved these changes
May 22, 2026
Collaborator
AndreasBackx
left a comment
AndreasBackx
left a comment
There was a problem hiding this comment.
Same as other PRs, good to have. Just remove the version change and like other PR rebase on main instead perhaps?
| self.option_name = option_name | ||
| self.possibilities: list[str] | None = None | ||
|
|
||
| # this temp variable avoids mypy complaining self.possibilities "reassignment" |
Collaborator
There was a problem hiding this comment.
Fine to remove this.
| self.command_name = command_name | ||
| self.possibilities: list[str] | None = None | ||
|
|
||
| # this temp variable avoids mypy complaining self.possibilities "reassignment" |
Collaborator
There was a problem hiding this comment.
Same as other comment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just like #3422 and #3451, this fills in the missing attribute type annotations for the error classes in
click.exceptions. This increases type coverage by 0.89% (91.5% -> 92.39%).