Open
Conversation
11 tasks
There was a problem hiding this comment.
Pull request overview
Refactors PolynomialPathFitter internals to make the path-fitting pipeline more modular and easier to evolve (per issue #4291), including moving shared helpers into CommonUtilities.
Changes:
- Adds a new public
OpenSim::choose(n, k)utility inCommonUtilities. - Moves
PolynomialPathFitterpipeline helpers into an anonymous namespace and introduces internalSettings/CoordinateMapfor configuration passing. - Centralizes property validation into a new
validateProperties()helper and updates data/model handling withinrun().
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| OpenSim/Common/CommonUtilities.h | Declares new choose() utility and cleans up trailing whitespace. |
| OpenSim/Common/CommonUtilities.cpp | Defines choose() implementation. |
| OpenSim/Actuators/PolynomialPathFitter.h | Updates header guard, refactors private helpers, adds runtime members and validation hook. |
| OpenSim/Actuators/PolynomialPathFitter.cpp | Refactors pipeline into internal helpers with Settings passed through; adds validateProperties() and updates run() flow. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 4 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
c6b743a to
c0a2dd8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partially addresses issue #4291
Brief summary of changes
This change refactors
PolynomialPathFitterto support future improvements as described in issue #4291.choose()toCommonUtilities.PolynomialPathFitter.cpp.CoordinateMapandSettingsfor passing configuration information to various parts of the path fitting pipeline.Other minor changes include:
CommonUtilities.Testing I've completed
Ran
testPolynomialPathFitter.cpp.Looking for feedback on...
CHANGELOG.md (choose one)
This change is