Skip to content

Remove custom e2e test job e2e-vsphere-operator-test#78328

Open
jsafrane wants to merge 1 commit intoopenshift:mainfrom
jsafrane:remove-vsphere-custom-test
Open

Remove custom e2e test job e2e-vsphere-operator-test#78328
jsafrane wants to merge 1 commit intoopenshift:mainfrom
jsafrane:remove-vsphere-custom-test

Conversation

@jsafrane
Copy link
Copy Markdown
Contributor

@jsafrane jsafrane commented Apr 24, 2026

The test is being moved to OTE in openshift/vmware-vsphere-csi-driver-operator#337

Summary by CodeRabbit

  • Chores
    • Removed the e2e-vsphere-operator-test from CI pipeline configurations across main, release-4.23, release-5.0, and release-5.1 branches. This eliminates the associated presubmit job definitions and test step configurations, streamlining the testing matrix.

@openshift-ci openshift-ci Bot requested review from dobsonj and rhrmo April 24, 2026 13:26
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 24, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 8e0275bb-3555-48a3-8ad6-d92b4d95092c

📥 Commits

Reviewing files that changed from the base of the PR and between 8986451 and b75e4ae.

📒 Files selected for processing (8)
  • ci-operator/config/openshift/vmware-vsphere-csi-driver-operator/openshift-vmware-vsphere-csi-driver-operator-main.yaml
  • ci-operator/config/openshift/vmware-vsphere-csi-driver-operator/openshift-vmware-vsphere-csi-driver-operator-release-4.23.yaml
  • ci-operator/config/openshift/vmware-vsphere-csi-driver-operator/openshift-vmware-vsphere-csi-driver-operator-release-5.0.yaml
  • ci-operator/config/openshift/vmware-vsphere-csi-driver-operator/openshift-vmware-vsphere-csi-driver-operator-release-5.1.yaml
  • ci-operator/jobs/openshift/vmware-vsphere-csi-driver-operator/openshift-vmware-vsphere-csi-driver-operator-main-presubmits.yaml
  • ci-operator/jobs/openshift/vmware-vsphere-csi-driver-operator/openshift-vmware-vsphere-csi-driver-operator-release-4.23-presubmits.yaml
  • ci-operator/jobs/openshift/vmware-vsphere-csi-driver-operator/openshift-vmware-vsphere-csi-driver-operator-release-5.0-presubmits.yaml
  • ci-operator/jobs/openshift/vmware-vsphere-csi-driver-operator/openshift-vmware-vsphere-csi-driver-operator-release-5.1-presubmits.yaml
💤 Files with no reviewable changes (8)
  • ci-operator/config/openshift/vmware-vsphere-csi-driver-operator/openshift-vmware-vsphere-csi-driver-operator-release-4.23.yaml
  • ci-operator/config/openshift/vmware-vsphere-csi-driver-operator/openshift-vmware-vsphere-csi-driver-operator-release-5.0.yaml
  • ci-operator/config/openshift/vmware-vsphere-csi-driver-operator/openshift-vmware-vsphere-csi-driver-operator-main.yaml
  • ci-operator/jobs/openshift/vmware-vsphere-csi-driver-operator/openshift-vmware-vsphere-csi-driver-operator-release-5.0-presubmits.yaml
  • ci-operator/jobs/openshift/vmware-vsphere-csi-driver-operator/openshift-vmware-vsphere-csi-driver-operator-main-presubmits.yaml
  • ci-operator/jobs/openshift/vmware-vsphere-csi-driver-operator/openshift-vmware-vsphere-csi-driver-operator-release-4.23-presubmits.yaml
  • ci-operator/config/openshift/vmware-vsphere-csi-driver-operator/openshift-vmware-vsphere-csi-driver-operator-release-5.1.yaml
  • ci-operator/jobs/openshift/vmware-vsphere-csi-driver-operator/openshift-vmware-vsphere-csi-driver-operator-release-5.1-presubmits.yaml

Walkthrough

The changes remove the e2e-vsphere-operator-test test step from CI pipeline configurations and presubmit jobs across four release branches (main, release-4.23, release-5.0, release-5.1). This eliminates the operator E2E test execution that invoked make operator-e2e-test and its associated Prow trigger mappings.

Changes

Cohort / File(s) Summary
Test Step Configuration Removals
ci-operator/config/openshift/vmware-vsphere-csi-driver-operator/openshift-vmware-vsphere-csi-driver-operator-main.yaml, openshift-vmware-vsphere-csi-driver-operator-release-4.23.yaml, openshift-vmware-vsphere-csi-driver-operator-release-5.0.yaml, openshift-vmware-vsphere-csi-driver-operator-release-5.1.yaml
Removes the e2e-vsphere-operator-test test step definition (13 lines each) that executed make operator-e2e-test with cpu: 100m resource requests under the ipi-vsphere workflow across main and release branches.
Presubmit Job Removals
ci-operator/jobs/openshift/vmware-vsphere-csi-driver-operator/openshift-vmware-vsphere-csi-driver-operator-main-presubmits.yaml, openshift-vmware-vsphere-csi-driver-operator-release-4.23-presubmits.yaml, openshift-vmware-vsphere-csi-driver-operator-release-5.0-presubmits.yaml, openshift-vmware-vsphere-csi-driver-operator-release-5.1-presubmits.yaml
Deletes the pull-ci-*-e2e-vsphere-operator-test presubmit job definitions (80 lines each), including their Prow trigger mappings, rerun commands (/test ... e2e-vsphere-operator-test), and full pod specifications across main and release branches.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~4 minutes

🚥 Pre-merge checks | ✅ 12
✅ Passed checks (12 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately and concisely summarizes the main change: removing a custom e2e test job named e2e-vsphere-operator-test across multiple CI configuration files.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed The custom check for stable and deterministic Ginkgo test names does not apply to this PR, which only modifies CI/CD pipeline configuration files (YAML), not Go test source code containing Ginkgo test definitions.
Test Structure And Quality ✅ Passed Custom check not applicable; PR modifies only YAML CI/CD files, not Go test code.
Microshift Test Compatibility ✅ Passed PR only removes existing CI test job definitions from YAML configuration files; no new Ginkgo e2e tests are being added.
Single Node Openshift (Sno) Test Compatibility ✅ Passed PR modifies only YAML configuration files in CI pipeline directories to remove e2e-vsphere-operator-test job definitions. No new Ginkgo test code is introduced, therefore SNO test compatibility check is not applicable.
Topology-Aware Scheduling Compatibility ✅ Passed Pull request only modifies CI configuration files and test job definitions, not deployment manifests, operator code, or workload scheduling constraints.
Ote Binary Stdout Contract ✅ Passed The OTE Binary Stdout Contract check is not applicable to this PR as it contains only YAML CI configuration deletions with no source code changes.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed PR removes CI test infrastructure configuration from YAML files; no new Ginkgo e2e tests are added, making the custom check not applicable.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Apr 24, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jsafrane

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 24, 2026
@openshift-merge-bot openshift-merge-bot Bot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Apr 24, 2026
@openshift-merge-bot
Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@jsafrane: no rehearsable tests are affected by this change

Note: If this PR includes changes to step registry files (ci-operator/step-registry/) and you expected jobs to be found, try rebasing your PR onto the base branch. This helps pj-rehearse accurately detect changes when the base branch has moved forward.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Apr 24, 2026

@jsafrane: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant