NO-JIRA: Remove driver removal test

[jsafrane]

It's now in an openshift test extension, #337.

Summary by CodeRabbit

• Chores
  • Removed obsolete end-to-end test infrastructure and related test utilities.

[openshift-ci-robot]

@jsafrane: This pull request explicitly references no jira issue.

Details

In response to this:

It's now in an openshift test extension, #337.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 537bb7bc-8bde-4f80-ac5b-badaec23848d

📥 Commits

Reviewing files that changed from the base of the PR and between e91f95e and 25d1c02.

📒 Files selected for processing (3)

• Makefile
• test/e2e/operator_removal_test.go
• test/library/client.go

💤 Files with no reviewable changes (3)

• Makefile
• test/e2e/operator_removal_test.go
• test/library/client.go

---

Walkthrough

Removal of end-to-end test infrastructure including the operator-e2e-test Makefile target, the operator removal validation test suite, and an associated Kubernetes client configuration helper function used for testing.

Changes

Cohort / File(s)	Summary
Build Configuration Makefile	Removed operator-e2e-test target definition and associated Go test configuration (GO_TEST_PACKAGES, GO_TEST_FLAGS, test-unit prerequisite).
E2E Test Removal test/e2e/operator_removal_test.go	Deleted full test suite that validated operator removal workflow, including cluster operator availability checks, CSIDriver state transitions, and resource cleanup verification.
Test Helper Removal test/library/client.go	Removed NewClientConfigForTest function that constructed non-interactive Kubernetes client configuration for testing purposes.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

🚥 Pre-merge checks | ✅ 11 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Microshift Test Compatibility	⚠️ Warning	New Ginkgo e2e tests added in hybrid_environment.go use OpenShift APIs (configv1.ClusterOperator and operatorapi.ClusterCSIDriver) unavailable on MicroShift without proper protection mechanisms like [Skipped:MicroShift] labels or IsMicroShiftCluster() checks.	Add [Skipped:MicroShift] labels, [apigroup:config.openshift.io] and [apigroup:operator.openshift.io] tags, or wrap tests with exutil.IsMicroShiftCluster() checks to skip on MicroShift.

✅ Passed checks (11 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately summarizes the main change: removing a driver removal test that was relocated to an OpenShift test extension, as confirmed by the PR objectives.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	This PR only removes existing tests and does not add or modify any Ginkgo tests.
Test Structure And Quality	✅ Passed	PR removes standard Go test migrated to OpenShift Ginkgo tests; custom check targets Ginkgo patterns and is not applicable.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	This PR removes existing tests and does not introduce any new Ginkgo e2e tests. The SNO compatibility check applies only when new tests are added.
Topology-Aware Scheduling Compatibility	✅ Passed	This PR exclusively removes test infrastructure code and test-related Makefile targets. Since no deployment manifests, operator code, or controllers are added or modified, the check does not apply.
Ote Binary Stdout Contract	✅ Passed	This PR removes test files and a Makefile target. The repository contains no process-level code (main(), TestMain(), or init functions) that outputs to stdout, so the OTE Binary Stdout Contract cannot be violated.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	This PR only removes existing tests rather than adding new Ginkgo e2e tests. The files test/e2e/operator_removal_test.go and test/library/client.go no longer exist (both were deleted), and the Makefile target was removed. The custom check for IPv6 and Disconnected Network Test Compatibility is explicitly designed to flag when NEW Ginkgo e2e tests are added. Since no new tests are being introduced in this pull request, the check does not apply.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[jsafrane]

/hold
openshift/release#78328 must be merged first

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jsafrane

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [jsafrane]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@jsafrane: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-vsphere-operator-test	25d1c02	link	true	/test e2e-vsphere-operator-test

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.